fix: instructor info in course details api #34760
Conversation
| @@ -10,10 +10,10 @@ | |||
| class InstructorInfoSerializer(serializers.Serializer): | |||
| """ Serializer for instructor info """ | |||
| name = serializers.CharField(allow_blank=True) | |||
There was a problem hiding this comment.
Should this also be required=False?
There was a problem hiding this comment.
I'm assuming there has to at least be a name for instructor_info, though I'm not completely sure. The specific issue that courses have been running into is a missing organization field.
rayzhou-bit
deleted the
2u/fix/do-not-require-some-instructor-info-in-course-details
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Scheduling and Details page will sometimes error out due to
KeyError: "Got KeyError when attempting to get a value for fieldorganizationon serializerInstructorInfoSerializer.\nThe serializer field might be named incorrectly and not match any attribute or key on thedictinstance.\nOriginal exception text was: 'organization'.". Theorganizationfield is missing when serializing instructor info, which causes this error.This PR addresses this by making some fields in instructor info not required, mimicking legacy behavior.
Supporting information
https://2u-internal.atlassian.net/browse/TNL-11484
Testing instructions
Smoke test Scheduling and Details page to make sure this change does not break anything.