Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge several outline processors in into UserPartitionOutlineProcessor #34459

Open
kdmccormick opened this issue Apr 2, 2024 · 0 comments
Open
Labels
code health Proactive technical investment via refactorings, removals, etc.

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Apr 2, 2024

From this list of processors, the following processors wrap concepts which, under the hood, are implemented on the user_partitions framework:

  • ContentGatingOutlineProcessor
  • EnrollmentTrackPartitionGroupsOutlineProcessor
  • CohortPartitionGroupsOutlineProcessor
  • TeamPartitionGroupsOutlineProcessor (new as of this PR)

Theoretically, they could all be merged into a single UserPartitionOutlineProcessor, which would dedupe some business logic and ensure that any new user_partition schemes automatically work with learning_sequences.

Open questions:

  • is this as straightforward as I think it is, or are there leaky abstractions / edge cases we're going to hit?
  • performance regressions?
  • could the same refactoring be applied to block transformers?

CC @ormsbee

@kdmccormick kdmccormick added the code health Proactive technical investment via refactorings, removals, etc. label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Proactive technical investment via refactorings, removals, etc.
Projects
None yet
Development

No branches or pull requests

1 participant