Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey xblock not working properly inside the Mobile apps' webview #34012

Open
miankhalid opened this issue Jan 5, 2024 · 14 comments
Open

Survey xblock not working properly inside the Mobile apps' webview #34012

miankhalid opened this issue Jan 5, 2024 · 14 comments

Comments

@miankhalid
Copy link

Hi folks 👋

Here to report an issue with the Survey xBlock's display inside our Mobile apps, plz have a look at the screenshots below:

Example 1 Example 2

After some client-side CSS injection magic:

Example 1 Example 2

cc @forgotvas @moiz994 @touchapp @hassan6190

@miankhalid
Copy link
Author

@openedx/edx-infinity team would you folks be able to help here?

@rgraber rgraber removed this from Arch-BOM Jan 8, 2024
@eemaanamir
Copy link
Contributor

eemaanamir commented Feb 12, 2024

This issue has been resolved in this PR.

@ayesha-waris
Copy link
Contributor

@openedx/edx-infinity team would you folks be able to help here?

@miankhalid The issue has been resolved

@miankhalid
Copy link
Author

thanks @ayesha-waris, lemme ask my team to verify the fix on our end as well.

@miankhalid
Copy link
Author

@eemaanamir @ayesha-waris sadly, the issue isn't fully fixed. Plz have a look at the issues still occurring after the fix:

New line bug incase of Radio buttons Alignment issue incase of percentages

@miankhalid miankhalid reopened this Feb 12, 2024
@ayesha-waris
Copy link
Contributor

@eemaanamir @ayesha-waris sadly, the issue isn't fully fixed. Plz have a look at the issues still occurring after the fix:

New line bug incase of Radio buttons Alignment issue incase of percentages

@miankhalid Thanks for confirmation, will get back to you once its resolved properly

@eemaanamir
Copy link
Contributor

@miankhalid The new line issue is not reproducible on our end. Please take a look at the following screenshots. Varying dimensions have been used to test the problem.

Screenshot 2024-02-12 at 9 40 07 PM Screenshot 2024-02-12 at 9 40 28 PM

Furthermore, the alignment bug is also not visible.

Screenshot 2024-02-12 at 9 41 33 PM

How are you producing the alignment bug in the first place? To my understanding, the total sum of all the percentages should not exceed 100%, but that is not the case in the screenshot you provided. Are you producing the bug using CSS manipulation? If yes, maybe that is the culprit behind the issue.

@miankhalid
Copy link
Author

How are you producing the alignment bug in the first place? To my understanding, the total sum of all the percentages should not exceed 100%, but that is not the case in the screenshot you provided. Are you producing the bug using CSS manipulation? If yes, maybe that is the culprit behind the issue.

@forgotvas thoughts on these questions?

@forgotvas
Copy link

forgotvas commented Feb 13, 2024

hi @eemaanamir, that bug i can still reproduce on that xblock. Possible i can reproduce that because on device we have width that less than 767px that limited in @media css:
Снимок экрана 2024-02-13 в 10 56 24 | Снимок экрана 2024-02-13 в 10 54 23

Sum of percentages is not equal to 100 because it's a hard coded and i don't think that you have calculated css that depends on value there:

2024-02-13.10.54.53.mov

The new line issue still reproduced on my side, i went through html tags, possible that will help you to find a reason:

2024-02-13.11.04.13.mov

cc @miankhalid

@awais-ansari
Copy link
Contributor

This issue has been addressed in this PR.

@forgotvas
Copy link

hi @awais-ansari, i can confirm that bug with new line was fixed, percent vertical alignment looks good too, but there also exist new one bug with percentage:

New line(fixed) Percent vertical alignment (fixed) New percent bug with new line
new line vertical alignment new bug

cc @miankhalid

@forgotvas
Copy link

hi @awais-ansari, do you have any updates for this bug?
Simulator Screenshot - iPhone 15 Plus - 2024-03-21 at 12 07 13

cc @miankhalid

@awais-ansari
Copy link
Contributor

@eemaanamir Can you please confirm that it is fixed or not?

@awais-ansari
Copy link
Contributor

Here is a fix. #34408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants