Feat: add library page redirects #33723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhaugh
force-pushed
the
feat--create-runtime-mapping-for-v1-lib-keys-to-v2
branch
from
6de0e25
to
4e5f490
Compare
…o feat--add-library-page-redirects
…-platform into feat--add-library-page-redirects
|
Closing since we will not be doing a 1-1 mapping between v1 and v2 libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://2u-internal.atlassian.net/browse/TNL-11184
As a library author, navigating to a V1 library URL should bring me to the corresponding V2 lib once V2 libraries are rolled out.
Technical Details:
We’ll want to create a conditional in edx-platform/cms/djangoapps/contentstore/views/library.py’s _display_library view, that checks if we have lib authoring enabled AND V1 Libs are mapped to V2 libs. If that conditional is true, convert the v1 key to a v2 key and return a redirect to LIBRARY_AUTHORING_MICROFRONTEND_URL + '/library' + v2_key_string as a response.