Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check for dependencies from the edx GitHub org #33189

Closed
timmc-edx opened this issue Sep 6, 2023 · 3 comments · Fixed by #34549
Closed

Add CI check for dependencies from the edx GitHub org #33189

timmc-edx opened this issue Sep 6, 2023 · 3 comments · Fixed by #34549
Assignees

Comments

@timmc-edx
Copy link
Contributor

timmc-edx commented Sep 6, 2023

We occasionally end up with a Python dependency in edx-platform that comes from the edx GitHub org, which should not be the case -- dependencies that are specific to Open edX and that are used in the base requirements of an IDA should be maintained in the openedx GitHub org instead.

Ned has written some tooling to discover this for Python and NodeJS packages: https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/find_dependencies

The repo-tools scripts download the dependencies for all repos, and a single run takes about 2 hours. However, it should be possible to turn this into a CI check for a single repo by installing Python requirements as we normally do (and take advantage of GitHub Actions caching to speed this up), since the installed packages in the virtualenv will have the METADATA files we need for this analysis. Perhaps the script in repo-tools could be adjusted to read from a virtualenv. It's worth reusing the tool, since it has some smarts such as following redirects.

It's also possible we won't end up wanting to do this work, depending on what Axim decides about these "second party" repos.

This is related to #33189 which talks about a more generic workflow to accomplish this across the org.

@feanil feanil moved this to 🆕 New in Aximprovements Team Sep 6, 2023
@feanil feanil moved this from 🆕 New to 🔖 Ready in Aximprovements Team Nov 6, 2023
@thezaeemaanwar thezaeemaanwar self-assigned this Nov 14, 2023
@thezaeemaanwar thezaeemaanwar moved this from 🔖 Ready to 🏗 In progress in Aximprovements Team Nov 15, 2023
@thezaeemaanwar thezaeemaanwar moved this from 🏗 In progress to 📋 Backlog in Aximprovements Team Jan 19, 2024
@feanil feanil moved this from 📋 Backlog to 🔖 Ready in Aximprovements Team Feb 6, 2024
@salman2013 salman2013 moved this from 🔖 Ready to 🏗 In progress in Aximprovements Team Mar 21, 2024
@salman2013 salman2013 self-assigned this Mar 21, 2024
@salman2013 salman2013 moved this from 🏗 In progress to 👀 In review in Aximprovements Team Jun 11, 2024
@salman2013 salman2013 moved this from 👀 In review to ✅ Done in Aximprovements Team Jun 11, 2024
@feanil feanil closed this as completed Jun 13, 2024
@github-project-automation github-project-automation bot moved this to Done in Arch-BOM Jun 13, 2024
@timmc-edx
Copy link
Contributor Author

@feanil What work ended up resolving this? Also, the new link in the issue description links back to this issue. :-)

@feanil
Copy link
Contributor

feanil commented Jun 20, 2024

Ah, I thought the PR had auto linked,

#34549 merged which should resolve this.

@timmc-edx
Copy link
Contributor Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants