You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update: This didn't work, so we're updating the ADR to at least describe why we can't use this approach: openedx/edx-django-utils#345
We currently have to annotate individual Celery tasks with a decorator in order to get code-owner information. This causes Arch-BOM to get alerted sometimes due to missing decorators on new tasks. We've since learned of an alternative approach involving a signal, documented in ADR 3 of edx-django-utils.
Add a new signal receiver on task_prerun that sets a new custom attribute with the module of the task
You can give it a try, but my experimental change in #33180 didn't work. I think New Relic opens the transaction after task_prerun and closes the task before task_postrun, so this signals-based approach probably doesn't work.
Update: This didn't work, so we're updating the ADR to at least describe why we can't use this approach: openedx/edx-django-utils#345
We currently have to annotate individual Celery tasks with a decorator in order to get code-owner information. This causes Arch-BOM to get alerted sometimes due to missing decorators on new tasks. We've since learned of an alternative approach involving a signal, documented in ADR 3 of edx-django-utils.
task_prerun
that sets a new custom attribute with the module of the taskcode_owner
values, with no gapsset_code_owner_attribute_from_module
set_code_owner_attribute
andset_code_owner_attribute_from_module
calls/decorators from tasks in edx-platformThe text was updated successfully, but these errors were encountered: