Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run depsplorer on edx-platform #32604

Open
3 tasks
dianakhuang opened this issue Jun 29, 2023 · 10 comments
Open
3 tasks

Run depsplorer on edx-platform #32604

dianakhuang opened this issue Jun 29, 2023 · 10 comments
Labels
good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community

Comments

@dianakhuang
Copy link
Contributor

Run https://github.com/Nathan-Furnal/depslorer on edx-platform to see if there are any interesting dependencies we don't need anymore.

Acceptance Criteria

  • Get the results of a depslorer run
  • Record them to this ticket
  • Present at the next DEPR meeting
@dianakhuang dianakhuang converted this from a draft issue Jun 29, 2023
@dianakhuang dianakhuang added help wanted Ready to be picked up by anyone in the community good first issue A good task for a newcomer to start with labels Jun 29, 2023
@Anakin100100
Copy link

I can try to work on this

@dianakhuang dianakhuang moved this from Proposed to Accepted in DEPR: Deprecation & Removal Aug 24, 2023
@LakshyaKhatri
Copy link
Contributor

LakshyaKhatri commented Sep 10, 2023

Hi @dianakhuang! I gave it a try and I was able to find out the unused dependencies using desplorer. I've one question around this before I start digging deeper into checking which of the dependencies are actually not being used:

Right now, I'm only looking at the auto-generated *.txt files for deprecated packages, and then I'll use them as a reference to remove the unused dependencies in the *.in files. Am I heading in the right direction?

@LakshyaKhatri
Copy link
Contributor

Here the output from desplorer: Desplorer Output.md

Note that this is just the raw output, a lot of the dependencies are coming from inherited parent requirement files. Also, some of the .in files don't have a corresponding .txt files. I've to check them. Although, all the requirement files look pretty well documented, hope that will help me to navigate around easily.

I'll post the update soon. 😄

@LakshyaKhatri
Copy link
Contributor

Hi @dianakhuang! Attaching the detailed output of each package in the edx-platform repo: Unused packages.pdf

The sole package deserving a consideration for deprecation is packaging. I was planning to share my findings during the last DEPR meeting, but it appears the meeting may have been canceled?

Please advise on the next steps to proceed.

@dianakhuang
Copy link
Contributor Author

@LakshyaKhatri thank you! The DEPR meetings should still be going on. You should be find the calendar invite on this google calendar: https://calendar.google.com/calendar/u/0?cid=Y192ODZzaHJuZWdzaHNxZ3A0Zmoyazk0dTdiY0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t

We are meeting next Thursday.

@LakshyaKhatri
Copy link
Contributor

Thanks so much @dianakhuang. I will join this Thursday 😄 🙌🏽

@LakshyaKhatri
Copy link
Contributor

Hello again @dianakhuang, 👋🏽

just confirming once: as per the discussion we are going to remove the following dependencies:

  • packaging
  • diff-cover

correct?

@dianakhuang
Copy link
Contributor Author

@LakshyaKhatri yup!

@Abdujabbar
Copy link

@dianakhuang

Can I move forward with the current issue? Are you ok with that @LakshyaKhatri? If you don't have a time?

@LakshyaKhatri
Copy link
Contributor

@Abdujabbar yes, please go ahead 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community
Projects
Status: Accepted
Development

Successfully merging a pull request may close this issue.

4 participants