Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite node_modules copying in Bash #31606

Closed
2 tasks
kdmccormick opened this issue Jan 19, 2023 · 2 comments
Closed
2 tasks

Rewrite node_modules copying in Bash #31606

kdmccormick opened this issue Jan 19, 2023 · 2 comments

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Jan 19, 2023 •
edited
Loading

Background

Part of:

Subtasks

  • Create a sh (not bash) script scripts/assets/copy-node-modules.sh, re-implementing the functionality of pavelib/assets.py:process_npm_assets.
  • Replace the implemention of pavelib/assets.py:process_npm_assets with a simple call to the new shell script.

Notes

...
@kdmccormick kdmccormick mentioned this issue Jan 19, 2023
Closed
8 tasks
@kdmccormick kdmccormick linked a pull request Jan 19, 2023 that will close this issue
Make NPM post-processing agnostic to node_modules location #31519
Closed
@kdmccormick
Copy link
Member Author

Would be resolved by #31519

@kdmccormick kdmccormick changed the title Reimplement NPM post-processing in sh Rewrite node_modules copying in Bash Feb 21, 2023
@kdmccormick
Copy link
Member Author

Closed in favor of the parent issue: #31604

@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make NPM post-processing agnostic to node_modules location
1 participant
@kdmccormick