Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated notification pref version #2210

Merged
merged 3 commits into from
May 6, 2024

Conversation

AhtishamShahid
Copy link
Contributor

@AhtishamShahid AhtishamShahid commented May 6, 2024

TL;DR -
Updated notification app name to match the platform's name.

@AhtishamShahid AhtishamShahid requested a review from a team as a code owner May 6, 2024 05:36
@AhtishamShahid AhtishamShahid force-pushed the ahtisham/updated_app_name_for_notifications branch 2 times, most recently from f0a8f12 to a056bbd Compare May 6, 2024 05:45
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (8d2a572) to head (fcfec1c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2210   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files         193      193           
  Lines       21149    21149           
  Branches     1906     1906           
=======================================
  Hits        20104    20104           
  Misses        780      780           
  Partials      265      265           
Flag Coverage Δ
unittests 95.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: changed notification app name

chore: udpated package version
@AhtishamShahid AhtishamShahid force-pushed the ahtisham/updated_app_name_for_notifications branch from b577e06 to 5a997ec Compare May 6, 2024 06:16
@AhtishamShahid AhtishamShahid merged commit 51d84c1 into master May 6, 2024
11 checks passed
@AhtishamShahid AhtishamShahid deleted the ahtisham/updated_app_name_for_notifications branch May 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants