Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v6.7.0 version bump #2208

Closed
wants to merge 1 commit into from
Closed

chore: v6.7.0 version bump #2208

wants to merge 1 commit into from

Conversation

pomegranited
Copy link
Contributor

TL;DR - Prepare release version

What changed?

  • version now v6.7.0

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@pomegranited pomegranited requested a review from a team as a code owner April 19, 2024 06:11
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 19, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (43ae22a) to head (f28058e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2208   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files         191      191           
  Lines       21098    21098           
  Branches     1904     1904           
=======================================
  Hits        20055    20055           
  Misses        779      779           
  Partials      264      264           
Flag Coverage Δ
unittests 95.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pomegranited pomegranited enabled auto-merge (squash) April 19, 2024 06:17
@pomegranited
Copy link
Contributor Author

pomegranited commented Apr 19, 2024

Hi @mphilbrick211 @openedx/content-aurora

Could somebody help me out with this version bump by approving here and creating a new release? Sorry to ask, but I'm going on leave tomorrow, and we're trying to get these updates into Redwood, which is cutting soon.

Thanks!

@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Apr 22, 2024
@mphilbrick211 mphilbrick211 removed the request for review from a team April 22, 2024 13:01
@mphilbrick211
Copy link

Hi @pomegranited! I don't think Aurora is reviewing pull requests, but let me look into this.

@leangseu-edx
Copy link
Contributor

@pomegranited 6.7.0 had already been release. https://github.com/openedx/edx-ora2/releases/tag/6.7.0

Do you think this pr is still needed?

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Apr 26, 2024
@itsjeyd
Copy link

itsjeyd commented Apr 26, 2024

@mphilbrick211

I don't think Aurora is reviewing pull requests, ...

Per https://github.com/openedx/edx-ora2/blob/master/catalog-info.yaml#L16, Aurora maintains this repo. The file was created last month (by @jristau1984), so the info that it contains is probably up-to-date?

The main thing that's changed for this repo, I think, is that we should be pinging the Aurora team via @openedx/2u-aurora, and stop using the legacy @openedx/content-aurora handle.

Also, it's possible that the settings for this repo need some additional updates -- I tried requesting a review from @openedx/2u-aurora and it didn't work (auto-complete didn't turn up any results).

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Apr 26, 2024
auto-merge was automatically disabled April 30, 2024 02:59

Pull request was closed

@openedx-webhooks
Copy link

@pomegranited Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@pomegranited pomegranited deleted the jill/v6.7.0 branch April 30, 2024 02:59
@pomegranited
Copy link
Contributor Author

@leangseu-edx

6.7.0 had already been release. https://github.com/openedx/edx-ora2/releases/tag/6.7.0 Do you think this pr is still needed?

Oh good, yep, that's all I needed. Thank you!

@itsjeyd @mphilbrick211

The main thing that's changed for this repo, I think, is that we should be pinging the Aurora team via @openedx/2u-aurora, and stop using the legacy @openedx/content-aurora handle.

Noted, thank you :)

Also, it's possible that the settings for this repo need some additional updates -- I tried requesting a review from @openedx/2u-aurora and it didn't work (auto-complete didn't turn up any results).

I'm able to use the 2u handle ok? Not sure why it doesn't work for you.

@itsjeyd itsjeyd added duplicate This issue or pull request already exists elsewhere and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 30, 2024
@itsjeyd
Copy link

itsjeyd commented Apr 30, 2024

@pomegranited It works for me when I try to use it in a comment, but not in the context of the reviewers field:

image

(The screenshot doesn't show it but I also tried openedx/2u-aurora 😅)

Is it working everywhere for you?

@pomegranited
Copy link
Contributor Author

@itsjeyd Ah.. no, I can't request a review from 2u-aurora either. From github's docs:

Organization members with write access can also assign a pull request review to any person or team with read access to a repository.

Maybe 2u-aurora doesn't have read access to this repo? I'm unable to see the repo settings, so can't find out for myself.

@mphilbrick211 can you help?

@mphilbrick211
Copy link

@pomegranited @itsjeyd I'm going to check on this, as I'm not sure Aurora is still reviewing. If they are, I'll confirm if they need access.

@jristau1984
Copy link
Contributor

@mphilbrick211 yes, 2u-aurora needs to be added to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). duplicate This issue or pull request already exists elsewhere open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants