Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Notifications for staff. #2201

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Added Notifications for staff. #2201

merged 1 commit into from
Apr 22, 2024

Conversation

AhtishamShahid
Copy link
Contributor

@AhtishamShahid AhtishamShahid commented Apr 3, 2024

Ticket
https://2u-internal.atlassian.net/browse/INF-1304

Description

To implement notiifcation for staff installed openedx-events and created signal for notification when\ever there is new submission , and next step in work flow is staff grading.

todo : update ora version and add tests

@AhtishamShahid AhtishamShahid requested a review from a team as a code owner April 3, 2024 07:02
@AhtishamShahid AhtishamShahid marked this pull request as draft April 3, 2024 07:03
@AhtishamShahid AhtishamShahid marked this pull request as ready for review April 3, 2024 09:41
Copy link

@asadazam93 asadazam93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.05%. Comparing base (43ae22a) to head (c8fc9c2).

Files Patch % Lines
...ent/xblock/apis/submissions/submissions_actions.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2201   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files         191      193    +2     
  Lines       21098    21149   +51     
  Branches     1904     1906    +2     
=======================================
+ Hits        20055    20104   +49     
- Misses        779      780    +1     
- Partials      264      265    +1     
Flag Coverage Δ
unittests 95.05% <96.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhtishamShahid AhtishamShahid force-pushed the ahtisham/INF-1304 branch 2 times, most recently from dbc8bdd to 985e336 Compare April 18, 2024 09:35
Copy link
Contributor

@saadyousafarbi saadyousafarbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
there seems to be a conflict, can you please resolve that? Thanks!

s: added notification for staff

s: added notification for staff

s: updated version

s: updated version

fix: resolved failing tests

fix: resolved failing tests

feat: added unit test for notification util

feat: added unit test for notification util
@AhtishamShahid AhtishamShahid merged commit b42e68d into master Apr 22, 2024
11 checks passed
@AhtishamShahid AhtishamShahid deleted the ahtisham/INF-1304 branch April 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants