feat: draft assessment response serializer #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/2023-dual-ui #2067 +/- ##
====================================================
Coverage ? 94.99%
====================================================
Files ? 188
Lines ? 19254
Branches ? 1754
====================================================
Hits ? 18290
Misses ? 725
Partials ? 239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leangseu-edx
force-pushed
the
lk/recieved-assessments
branch
from
7dae282
to
41dadaf
Compare
nsprenkle
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Looks like there was some confusion over the contract. The grades should actually be under the top-level assessments key returned from page context. This is currently under submission key.
{
"assessments":
{
effectiveAssessmentType: "staff", "peer", or "self"
"staff": (Optional)
{
stepScore: (Score)
assessment: (Assessment Data Shape)
}
"peers": (Optional)[]
{
stepScore: (Score)
assessments: (Assessment Data Shape)[]
}
"peerUnweighted": (Optional)
{
stepScore: Null
assessments: (Assessment Data Shape)[]
}
"self": (Optional)
{
stepScore: (Score shape)
assessment: (Assessment Data Shape)
}
}
}
987247d
to
6cc88d9
Compare
nsprenkle
requested changes
Oct 11, 2023
openassessment/xblock/ui_mixins/mfe/test_page_context_serializer.py
Outdated
Show resolved
Hide resolved
leangseu-edx
force-pushed
the
lk/recieved-assessments
branch
from
3fb97c9
to
4494b80
Compare
nsprenkle
approved these changes
Oct 12, 2023
chore: update tests chore: update tests chore: add self step chore: update requested change chore: update shape
leangseu-edx
force-pushed
the
lk/recieved-assessments
branch
from
4494b80
to
b2d849d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge to feat/2023-dual-ui
What changed:
Test:
/xblock/:id/handler/get_block_learner_assessment_data/self/xblock/:id/handler/get_block_learner_assessment_data/staff,/xblock/:id/handler/get_block_learner_assessment_data/peer