Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using get_course for course lookup in modulestore #2064

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

jszewczulak
Copy link
Contributor

TL;DR - As it turns out to do course block lookup using modulestore and CourseKey we need to call get_course method, get_item gives error when passing CourseKey

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@jszewczulak jszewczulak requested a review from a team as a code owner October 3, 2023 16:25
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9f105e5) 94.93% compared to head (d2d149b) 94.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         183      183           
  Lines       18621    18623    +2     
  Branches     1704     1704           
=======================================
+ Hits        17677    17679    +2     
  Misses        712      712           
  Partials      232      232           
Flag Coverage Δ
unittests 94.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)
...nt/workflow/test/test_workflow_batch_update_api.py 99.19% <100.00%> (+<0.01%) ⬆️
...enassessment/workflow/workflow_batch_update_api.py 80.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jszewczulak jszewczulak merged commit b395329 into master Oct 3, 2023
7 checks passed
@jszewczulak jszewczulak deleted the js/modulestore branch October 3, 2023 19:01
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants