feat: mfe file actions with legacy refactor #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansenk
requested review from
leangseu-edx,
mattcarter,
muselesscreator and
nsprenkle
nsprenkle
reviewed
Sep 29, 2023
There was a problem hiding this comment.
Looks good, only not approving because the paths differ from our contract. Make sure to update to align to contract or update the contract and communicate changes to @muselesscreator
leangseu-edx
force-pushed
the
jkantor/submission-bff
branch
from
2c50e26
to
f20269c
Compare
jansenk
changed the title
nsprenkle
reviewed
Oct 13, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/2023-dual-ui #2059 +/- ##
====================================================
Coverage ? 94.96%
====================================================
Files ? 189
Lines ? 19433
Branches ? 1766
====================================================
Hits ? 18455
Misses ? 738
Partials ? 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
* feat: submission mfe bff endpoints and api * refactor: legacy upload files * refactor: legacy delete file * refactor: legacy file upload url generation * refactor: has any files in upload space * refactor: suffix constants * feat: add mfe file json handlers
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
* feat: submission mfe bff endpoints and api * refactor: legacy upload files * refactor: legacy delete file * refactor: legacy file upload url generation * refactor: has any files in upload space * refactor: suffix constants * feat: add mfe file json handlers
nsprenkle
pushed a commit
that referenced
this pull request
Nov 6, 2023
* feat: submission mfe bff endpoints and api * refactor: legacy upload files * refactor: legacy delete file * refactor: legacy file upload url generation * refactor: has any files in upload space * refactor: suffix constants * feat: add mfe file json handlers
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
* feat: submission mfe bff endpoints and api * refactor: legacy upload files * refactor: legacy delete file * refactor: legacy file upload url generation * refactor: has any files in upload space * refactor: suffix constants * feat: add mfe file json handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - File actions refactors and BFF MFE endpoints
JIRA: AU-1391
What changed?
Developer Checklist
FYI: @openedx/content-aurora