From 13632cedc912792b09be43e18764af6cbf6f4ffb Mon Sep 17 00:00:00 2001 From: Jansen Kantor Date: Tue, 10 Sep 2024 14:30:02 -0400 Subject: [PATCH] fix: add config for optional firefox headless --- karma.conf.js | 19 ++++++++++++++++--- package-lock.json | 30 ++++++++++++++++++++++++++++-- package.json | 3 ++- 3 files changed, 46 insertions(+), 6 deletions(-) diff --git a/karma.conf.js b/karma.conf.js index d4b214e252..e0baf16c0f 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -17,7 +17,8 @@ module.exports = function(config) { 'karma-sinon', 'karma-jasmine-html-reporter', 'karma-spec-reporter', - 'karma-webpack' + 'karma-webpack', + require("karma-firefox-launcher") ], // frameworks to use @@ -107,7 +108,13 @@ module.exports = function(config) { // start these browsers // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher - browsers: ['HeadlessChrome'], + + browsers: [ + 'HeadlessChrome' + // 'HeadlessFirefox' + ], + // If chrome headless is not working, try swapping out which line is commented above + // to use firefox for local dev customLaunchers: { HeadlessChrome: { base: 'ChromeHeadless', @@ -118,7 +125,13 @@ module.exports = function(config) { '--disable-translate', '--disable-extensions' ] - } + }, + HeadlessFirefox: { + base: 'Firefox', + flags: [ + '--headless', + ] + }, }, // Continuous Integration mode diff --git a/package-lock.json b/package-lock.json index 17b23290ff..0489635113 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "edx-ora2", - "version": "6.11.3", + "version": "6.11.4", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "edx-ora2", - "version": "6.11.0", + "version": "6.11.4", "dependencies": { "@edx/frontend-build": "8.0.6", "@openedx/paragon": "^21.5.7", @@ -36,6 +36,7 @@ "karma": "^6.3.9", "karma-chrome-launcher": "^2.2.0", "karma-coverage": "^2.1.0", + "karma-firefox-launcher": "^2.1.3", "karma-jasmine": "4.0.0", "karma-jasmine-html-reporter": "~0.2", "karma-jasmine-jquery": "git+https://github.com/nkoder/karma-jasmine-jquery.git#be1566e6a069c867812b3845a46c9c6ca73b1e9f", @@ -17929,6 +17930,31 @@ "semver": "bin/semver.js" } }, + "node_modules/karma-firefox-launcher": { + "version": "2.1.3", + "resolved": "https://registry.npmjs.org/karma-firefox-launcher/-/karma-firefox-launcher-2.1.3.tgz", + "integrity": "sha512-LMM2bseebLbYjODBOVt7TCPP9OI2vZIXCavIXhkO9m+10Uj5l7u/SKoeRmYx8FYHTVGZSpk6peX+3BMHC1WwNw==", + "dev": true, + "dependencies": { + "is-wsl": "^2.2.0", + "which": "^3.0.0" + } + }, + "node_modules/karma-firefox-launcher/node_modules/which": { + "version": "3.0.1", + "resolved": "https://registry.npmjs.org/which/-/which-3.0.1.tgz", + "integrity": "sha512-XA1b62dzQzLfaEOSQFTCOd5KFf/1VSzZo7/7TUjnya6u0vGGKzU96UQBZTAThCb2j4/xjBAyii1OhRLJEivHvg==", + "dev": true, + "dependencies": { + "isexe": "^2.0.0" + }, + "bin": { + "node-which": "bin/which.js" + }, + "engines": { + "node": "^14.17.0 || ^16.13.0 || >=18.0.0" + } + }, "node_modules/karma-jasmine": { "version": "4.0.0", "resolved": "https://registry.npmjs.org/karma-jasmine/-/karma-jasmine-4.0.0.tgz", diff --git a/package.json b/package.json index a56b9b8565..857e6a4505 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "edx-ora2", - "version": "6.11.3", + "version": "6.11.4", "repository": "https://github.com/openedx/edx-ora2.git", "dependencies": { "@edx/frontend-build": "8.0.6", @@ -31,6 +31,7 @@ "karma": "^6.3.9", "karma-chrome-launcher": "^2.2.0", "karma-coverage": "^2.1.0", + "karma-firefox-launcher": "^2.1.3", "karma-jasmine": "4.0.0", "karma-jasmine-html-reporter": "~0.2", "karma-jasmine-jquery": "git+https://github.com/nkoder/karma-jasmine-jquery.git#be1566e6a069c867812b3845a46c9c6ca73b1e9f",