-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add migration to create PA role #2181
Conversation
283fc71
to
8739c0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions:
-
We need to add tests for this new role in:
https://github.com/openedx/edx-enterprise/blob/master/tests/test_roles_api.py -
Make sure we are validating all tests in this file on this newly added role:
https://github.com/openedx/edx-enterprise/blob/master/tests/test_models.py#L2323 -
Update this file to add helper methods for this new role:
https://github.com/openedx/edx-enterprise/blob/master/enterprise/roles_api.py -
Can we also look at the usage of
get_or_create_system_wide_role
in code to see whether we should be doing this via migration or this utility?
414e637
to
7906511
Compare
|
…200/new-role-in-lms
7906511
to
8a96ac0
Compare
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.