This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Refactoring code for Django 4.2 #4073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumarkhan999
force-pushed
the
upgrade-django-42
branch
from
cd4b343
to
6ddbaea
Compare
mumarkhan999
force-pushed
the
zubair-django-oscar322-update
branch
3 times, most recently
from
2ac68b3
to
6b4c938
Compare
mumarkhan999
force-pushed
the
upgrade-django-42
branch
from
4a78c78
to
ea08e15
Compare
mumarkhan999
force-pushed
the
upgrade-django-42
branch
from
8654ee0
to
380115d
Compare
mumarkhan999
force-pushed
the
upgrade-django-42
branch
from
380115d
to
1ee62a3
Compare
mumarkhan999
force-pushed
the
upgrade-django-42
branch
from
729fb49
to
cfad331
Compare
mumarkhan999
force-pushed
the
upgrade-django-42
branch
from
515a98e
to
ba7b3d4
Compare
UsamaSadiq
approved these changes
Dec 21, 2023
| @@ -40,5 +40,5 @@ def process_view(self, request, view_func, view_args, view_kwargs): # pylint: d | |||
| # If the user does not already have an LMS user id, add it | |||
| called_from = u'middleware with request path: {request}, referrer: {referrer}'.format( | |||
| request=request.get_full_path(), | |||
| referrer=request.META.get('HTTP_REFERER')) | |||
| referrer=request.headers.get('referer')) | |||
There was a problem hiding this comment.
We can skip this change for now as both are supported with Django 42
| @@ -2,9 +2,9 @@ name: CI | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [master] | |||
| branches: ['*'] | |||
There was a problem hiding this comment.
Is this change intentional? If yes, we can instead use only the headers to achieve the same purpose so following will work as well for all branches
on:
push:
pull_request:
| @@ -5,7 +5,7 @@ on: | |||
| pull_request: | |||
| push: | |||
| branches: | |||
There was a problem hiding this comment.
Similarly this can also be changed to only following:
on:
push:
| @@ -34,7 +34,7 @@ class StripeWebhooksView(APIView): | |||
| @csrf_exempt | |||
| def post(self, request): | |||
| payload = request.body | |||
| sig_header = request.META['HTTP_STRIPE_SIGNATURE'] | |||
| sig_header = request.headers['stripe-signature'] | |||
There was a problem hiding this comment.
We can skip this change for Django 42 support as well.
Suggested change
| sig_header = request.headers['stripe-signature'] | |
| sig_header = request.META['HTTP_STRIPE_SIGNATURE'] |
| @@ -31,7 +31,7 @@ class Command(BaseCommand): | |||
| help = 'Compile and collect assets' | |||
|
|
|||
| # NOTE (CCB): This allows us to compile static assets in Docker containers without database access. | |||
| requires_system_checks = False | |||
| requires_system_checks = [] | |||
There was a problem hiding this comment.
Is this change intentional?
| enterprise_views.EnterpriseCustomerCatalogsViewSet.as_view({'get': 'get'}), | ||
| name='enterprise_customer_catalogs' | ||
| ), | ||
| url( | ||
| r'^customer_catalogs/(?P<enterprise_catalog_uuid>[^/]+)$', | ||
| path( |
There was a problem hiding this comment.
Suggested change
| path( | |
| re_path( |
| url( | ||
| r'^customer_catalogs/(?P<enterprise_catalog_uuid>[^/]+)$', | ||
| path( | ||
| 'customer_catalogs/<str:enterprise_catalog_uuid>', |
There was a problem hiding this comment.
Suggested change
| 'customer_catalogs/<str:enterprise_catalog_uuid>', | |
| r'^customer_catalogs/(?P<enterprise_catalog_uuid>[^/]+)$', |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.
Useful information to include:
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?
Other information
Include anything else that will help reviewers and consumers understand the change.