fix: Embargo API fixed with new product type. #4034
Conversation
| 'user': user.username, | ||
| # ip variable is None when testing it locally, giving it dummy string "test_local_ip" | ||
| # just to bypass the API, otherwise API returns "Missing Parameters" response. | ||
| 'ip_address': ip or "test_local_ip", |
There was a problem hiding this comment.
we should not have a test string hard coded here, especially if it's only for local testing. if we need behavior that varies whether you are in a local dev environment vs stage/prod, i recommend we instead use a config variable that, if true, will override what the ip variable with something that works. that way, we prevent a user from potentially spoofing the values in their context to trigger this test behavior
| product_class_name = product.get_product_class().name | ||
|
|
||
| # We are checking Seats & Course Entitlement | ||
| if product_class_name == SEAT_PRODUCT_CLASS_NAME or product_class_name == COURSE_ENTITLEMENT_PRODUCT_CLASS_NAME: |
There was a problem hiding this comment.
The last time when I reported this issue I tried using the same fix but it didn't work since for course entitlement products we didn't have course attribute set on them and hence the code would raise attribute errors as far as I remember. I would recommend double checking the code by debugging it locally and testing all the scenarios.
Course Entitlementto be checked by Embargo while adding to the bucket.test_local_ipto bypass API checks for local testing.