fix: same title for Cybersource and LiqPay buttons for legacy #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
mphilbrick211
added
the
needs test run
DmytroAlipov
force-pushed
the
fix-same-title-to-palm
branch
3 times, most recently
from
4cc81a5
to
a90bd30
Compare
e0d
removed
the
needs test run
|
Hi @colinbrash and @openedx/revenue-squad! Could someone please review/merge this for us? Thanks! |
DmytroAlipov
force-pushed
the
fix-same-title-to-palm
branch
4 times, most recently
from
3fc9063
to
963e335
Compare
mphilbrick211
added
the
waiting for eng review
DmytroAlipov
force-pushed
the
fix-same-title-to-palm
branch
3 times, most recently
from
020e920
to
a391fd4
Compare
DmytroAlipov
force-pushed
the
fix-same-title-to-palm
branch
from
a391fd4
to
c9962ec
Compare
|
This is a merge into Palm. The BTR group can review and merge it. |
@nedbat hi there! Just following up to see if this can be merged? |
mphilbrick211
added
the
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport from master
Description
For the legacy page of the course payment selection, there is a scenario when we have two Checkout buttons. It is not clear what payment they are intended for.
This is how it looks after fixing: