Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: same title for Cybersource and LiqPay buttons for legacy #4009

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: same title for Cybersource and LiqPay buttons for legacy #4009

wants to merge 2 commits into from

Conversation

DmytroAlipov
Copy link
Contributor

Description

For the legacy page of the course payment selection, there is a scenario when we have two Checkout buttons. It is not clear what payment they are intended for.

cybersource_liqpay_buttons

This is how it looks after fixing:

screen_32

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner July 22, 2023 08:12
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 22, 2023 •
edited
Loading

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 22, 2023
@DmytroAlipov DmytroAlipov mentioned this pull request Jul 22, 2023
Open
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 24, 2023
@DmytroAlipov DmytroAlipov force-pushed the fix-same-title-to-master branch 3 times, most recently from fc81ca2 to c95cd06 Compare July 28, 2023 10:48
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 28, 2023
@mphilbrick211
Copy link

Hi @openedx/revenue-squad! Would someone be able to please review/merge this for us?

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 7, 2023
@DmytroAlipov DmytroAlipov force-pushed the fix-same-title-to-master branch 4 times, most recently from e6e396a to 76e2907 Compare August 18, 2023 19:12
@cmltaWt0
Copy link
Contributor

@mphilbrick211 could we boost this?

@mphilbrick211
Copy link

Hi @cmltaWt0! I did escalate this within 2U, but am waiting to hear on an ETA for review. I apologize for the delay.

@mphilbrick211
Copy link

Hi @openedx/revenue-squad! Could we please get an update on getting this reviewed? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Contributions
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DmytroAlipov @openedx-webhooks @mphilbrick211 @cmltaWt0 @e0d