Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

refactor: Use Stripe webhook endpoint on payment flow #3913

Closed
wants to merge 4 commits into from

Conversation

julianajlk
Copy link
Contributor

@julianajlk julianajlk commented Feb 20, 2023

REV-3242.

After Payment Intent confirmation with Stripe, ecommerce should receive POST request with a payment_intent.succeeded event from Stripe in the webhook endpoint, which should then trigger the remainder of order creation, processor response saving, event tracking, etc.

SDN check remains before the Payment Intent is confirmed, which happens before the webhook endpoint is called.

TODOS/Issues:

  • This is WIP, not completely working yet.
  • Need to better organize which re-used methods should be under which classes and mixins. Some logic moved to the webhooks class, however they had methods/referenced methods in other classes (currently just importing the specific class).
  • The StripeCheckoutView post method needs to return a Response. With the refactor, returning a response to the Receipt Page is moved to webhook payment intent succeeded handler function. Need a processing URL instead so the view can return something.
  • Need to integrate with feat: Initial 3DS implementation and handle requires_action status #3904
  • Need to check idempotency on the webhook event type.

@julianajlk julianajlk force-pushed the julianajlk/REV-3242/webhooks-payment-flow branch 4 times, most recently from 3ba46d8 to 1cc88df Compare February 20, 2023 10:03
@julianajlk julianajlk force-pushed the julianajlk/REV-3242/webhooks-payment-flow branch from 4bcdac1 to 72034d7 Compare March 6, 2023 19:24
@julianajlk julianajlk force-pushed the julianajlk/REV-3242/webhooks-payment-flow branch from 72034d7 to e808000 Compare March 6, 2023 19:57
@feanil feanil closed this Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants