feat: upgrade edx-drf-extensions and newrelic #4027
Conversation
|
Cla check hung, so closing and reopening. |
|
[inform] @christopappas: I've got another change (under development) that I want to bring in, so I'll probably just leave this until then. or, if we want fewer changes at a time, feel free to merge this. I am not able to merge. |
robrap
force-pushed
the
robrap/upgrade-edx-drf-extensions
branch
from
43b33ef
to
ef2d7dc
Compare
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| django-ses | |||
| gunicorn==19.7.1 | |||
| newrelic<5 | |||
| newrelic | |||
There was a problem hiding this comment.
Note to reviewer: This was an outdated constraint from before constraints.txt existed, and based on constraining against major version upgrades as a rule, not due to a particular known issue.
Note that the other constraints in here are likely also an issue, but are riskier so I'll them to the owning team. I figured it would be good to have the latest monitoring capabilities though, like getting logs into New Relic.
The two commits are simple to review separately. Please re-review when you get the chance. Again, I haven't toggled anything on in ecommerce, but I do plan to once this has been deployed. |
|
@christopappas: It looks like there is a failing test, so I'll need to look into that first. |
The method generate_unversioned_payload in edx-drf-extensions now requires a user.id to function, so that needed to be added to the mock user.
Upgrade edx-drf-extensions to 8.12.0. This was done using a temporary constraint and pip-compile without the --upgrade to keep from upgrading unrelated requirements.
Upgrade newrelic to 9.1.0. This was done using a temporary constraint and pip-compile without the --upgrade to keep from upgrading unrelated requirements.
robrap
force-pushed
the
robrap/upgrade-edx-drf-extensions
branch
from
c2d123a
to
d8e3178
Compare
| @@ -137,6 +137,7 @@ def generate_new_user_token(self, username, email, is_staff): | |||
| # create a mock user, and not the actual user, because we want to confirm that | |||
| # the user is created during JWT authentication | |||
| user = Mock() | |||
| user.id = 1 | |||
There was a problem hiding this comment.
Note to reviewer: I updated the edx-drf-extensions CHANGELOG in openedx/edx-drf-extensions#393 to note this test utility change.
robrap
changed the title
* fix: test update for edx-drf-extensions 8.11.0 The method generate_unversioned_payload in edx-drf-extensions now requires a user.id to function, so that needed to be added to the mock user. * feat: upgrade edx-drf-extensions Upgrade edx-drf-extensions to 8.12.0. This was done using a temporary constraint and pip-compile without the --upgrade to keep from upgrading unrelated requirements. * feat: upgrade newrelic Upgrade newrelic to 9.1.0. This was done using a temporary constraint and pip-compile without the --upgrade to keep from upgrading unrelated requirements.
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description