Fix: 500 error during opening program certificate page #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
DmytroAlipov
force-pushed
the
fix-org-image-palm
branch
4 times, most recently
from
298bce7
to
cbf830b
Compare
mphilbrick211
added
the
backport
|
Hi @openedx/2u-phoenix! This is ready as soon as the master is merged. |
DmytroAlipov
force-pushed
the
fix-org-image-palm
branch
2 times, most recently
from
aca567c
to
5ddaf09
Compare
DmytroAlipov
force-pushed
the
fix-org-image-palm
branch
from
5ddaf09
to
7ace944
Compare
Error 500 occurs when going to the program certificate page if an organization is connected to the Authoring organizations field with an empty field Certificate logo image.
DawoudSheraz
approved these changes
Jan 22, 2024
DawoudSheraz
merged commit 36dc3d6
into
openedx:open-release/palm.master
20 checks passed
|
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport from the master.
Description:
Error 500 occurs when going to the Program certificate page if an organization is connected to the
Authoring organizationsfield with an empty fieldCertificate logo image:Steps to Reproduce:
Authoring organizationsfield that does not have an image loaded for theCertificate logo image field:I propose that before saving the program, verify if the Certificate logo image field of the associated organizations is empty. Also, make the certificate_logo_image field required to be filled in the admin panel, but not in the model, to prevent unnecessary migrations.
On the Program page
https://<discovery>/admin/course_metadata/program/:On the Organization page
https://<discovery>/admin/course_metadata/organization/: