fix: [WS-4468] update learning type experiment filter #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseverino
force-pushed
the
bseverino/WS-4468-update-learning-type-experiment
branch
2 times, most recently
from
f117a6f
to
8f41fc4
Compare
Comment on lines
71
to
73
| return product_map[product_type] | ||
| except KeyError: | ||
| return product_type |
There was a problem hiding this comment.
this can be re-written to product_map.get(product_type, product_type)
|
|
||
| product_map = { | ||
| 'Boot Camp': _('Boot Camps'), | ||
| 'Executive Education': _('Exec Ed'), |
There was a problem hiding this comment.
should it be Exec Ed? Wouldn't the complete Executive Education make sense?
There was a problem hiding this comment.
I double checked with product, they requested this label specifically
There was a problem hiding this comment.
Just got a request to change it back to Executive Education
zawan-ila
approved these changes
Apr 29, 2024
bseverino
force-pushed
the
bseverino/WS-4468-update-learning-type-experiment
branch
2 times, most recently
from
08ff179
to
bb00e04
Compare
DawoudSheraz
approved these changes
May 6, 2024
bseverino
force-pushed
the
bseverino/WS-4468-update-learning-type-experiment
branch
from
bb00e04
to
fd92d30
Compare
|
Flagging this again, should be ready to be merged but CI seems to be stuck |
bseverino
force-pushed
the
bseverino/WS-4468-update-learning-type-experiment
branch
from
fd92d30
to
5459ff8
Compare
bseverino
force-pushed
the
bseverino/WS-4468-update-learning-type-experiment
branch
from
5459ff8
to
70d899c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ticket: https://2u-internal.atlassian.net/browse/WS-4468
Update fields for the learning type experiment filter based on product specs, plus some code cleanup: