Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 500 error during opening program certificate page (Quince) #4183

Conversation

DmytroAlipov
Copy link
Contributor

This is backport from the master.

Description:

Error 500 occurs when going to the Program certificate page if an organization is connected to the Authoring organizations field with an empty field Certificate logo image:
screen_105


Steps to Reproduce:

  1. The program is created.
  2. In the Discovery admin panel, connect an organization in the Authoring organizations field that does not have an image loaded for the Certificate logo image field:
screen_106 screen_107
  1. Earn a program certificate as a user.
  2. Go to the program certificate page.

I propose that before saving the program, verify if the Certificate logo image field of the associated organizations is empty. Also, make the certificate_logo_image field required to be filled in the admin panel, but not in the model, to prevent unnecessary migrations.

On the Program page https://<discovery>/admin/course_metadata/program/:
screen_220

On the Organization page https://<discovery>/admin/course_metadata/organization/:
screen_221

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 13, 2023
@mphilbrick211
Copy link

Hi @openedx/2u-phoenix! This is ready after the master is merged.

Error 500 occurs when going to the program certificate page if
an organization is connected to the Authoring organizations
field with an empty field Certificate logo image.
@DawoudSheraz DawoudSheraz merged commit 3ee05ab into openedx:open-release/quince.master Jan 22, 2024
14 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-org-image-quince branch January 22, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants