Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add remaining language tags #4149

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: add remaining language tags #4149

merged 1 commit into from
Oct 17, 2023

Conversation

AfaqShuaib09
Copy link
Contributor

@AfaqShuaib09 AfaqShuaib09 commented Oct 16, 2023

PROD-3675

This PR adds remaining language tags to discovery from following lists. Currently, most of following languages available in discovery with variants instead of simple one.
This PR adds simple variant of below mentioned language.

List of Missing Languages:
Arabic
French
German
Portuguese
Spanish

Copy link
Contributor

@zawan-ila zawan-ila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for myself] How do you generate this migration file? I would assume manually but it has the Generate by django on top so part of it is automated?

@AfaqShuaib09
Copy link
Contributor Author

[for myself] How do you generate this migration file? I would assume manually but it has the Generate by django on top so part of it is automated?

I've created it using following command

./manage.py makemigration {app-name} --emtpy

--empty option will an empty migration file

@AfaqShuaib09 AfaqShuaib09 merged commit 5061550 into master Oct 17, 2023
14 checks passed
@AfaqShuaib09 AfaqShuaib09 deleted the afaq/prod_3675 branch October 17, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants