Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Remove checks from branch protection rules in edx-notes-api #943

Closed
iamsobanjaved opened this issue Oct 18, 2023 · 8 comments
Closed
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@iamsobanjaved
Copy link

Firm Name

2U

Urgency

Medium (< 2 weeks)

Requested Change

Kindly remove these checks from branch protection rules, in the edx-notes-api repo

  • build (py38, django32, mysql57)
  • build (py38, django32, mysql80)

Reasoning

We want to merge Django upgrade PR, but these checks are stopping us. We can disable these for now, and enable Django 4.2 once we merge the upgrade PR

Django upgrade PR: openedx/edx-notes-api#349

@iamsobanjaved iamsobanjaved added the github-request Request for change to access level or settings in the openedx GitHub organization. label Oct 18, 2023
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@bmtcril bmtcril self-assigned this Oct 18, 2023
@bmtcril
Copy link
Contributor

bmtcril commented Oct 18, 2023

@iamsobanjaved these checks have been removed for now. I'm going to keep this open as a reminder to follow up, but please let me know when I can enable the new checks.

@bmtcril bmtcril moved this from Backlog to Blocked in Axim Engineering Tasks Oct 18, 2023
@bmtcril
Copy link
Contributor

bmtcril commented Oct 19, 2023

@iamsobanjaved it looks like the 4.2 PR has merged, can I enable branch protections for build (py38, django42, mysql80)?

@iamsobanjaved
Copy link
Author

Its not yet deployed on production and also hit an issue on stage. I will let you know once it reaches prod successfully

@sarina
Copy link
Contributor

sarina commented Dec 19, 2023

@iamsobanjaved is this issue ready to move forward?

@feanil
Copy link
Contributor

feanil commented Jan 3, 2024

@iamsobanjaved checking back in on this, are we clear to add django 4.2 tests as required for the notes api app?

@feanil feanil self-assigned this Jan 3, 2024
@iamsobanjaved
Copy link
Author

Yeah, we can mark Django 4.2 tests as required now.

@feanil
Copy link
Contributor

feanil commented Jan 10, 2024

This is all set.

@feanil feanil closed this as completed Jan 10, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Axim Engineering Tasks Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

4 participants