Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Remove checks from branch protection rules in Course Discovery #923

Closed
iamsobanjaved opened this issue Oct 10, 2023 · 7 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@iamsobanjaved
Copy link

Firm Name

2U

Urgency

Medium (< 2 weeks)

Requested Change

Kindly remove these checks from branch protection rules, in the course-discovery repo

  • pytest (py38, django32, mysql57, 1)
  • pytest (py38, django32, mysql57, 2)
  • pytest (py38, django32, mysql57, 3)
  • pytest (py38, django32, mysql57, 4)
  • pytest (py38, django32, mysql57, 5)
  • pytest (py38, django32, mysql57, 6)

Ref PR: openedx/course-discovery#4088

Reasoning

We want to merge Django upgrade PR, but these checks are stopping us. We can disable these for now, and enable Django 4.2 once we merge the upgrade PR

@iamsobanjaved iamsobanjaved added the github-request Request for change to access level or settings in the openedx GitHub organization. label Oct 10, 2023
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@kdmccormick kdmccormick self-assigned this Oct 10, 2023
@kdmccormick kdmccormick moved this from Backlog to To Do in Axim Engineering Tasks Oct 10, 2023
@kdmccormick
Copy link
Member

Django 3.2 checks are no longer required. Just ping me on this ticket again when you want the Django 4.2 checks marked as required.

Here's what the checks looked like before, for our reference:
Image

@kdmccormick kdmccormick moved this from To Do to Blocked in Axim Engineering Tasks Oct 12, 2023
@kdmccormick
Copy link
Member

@iamsobanjaved Should I make the Django 4.2 unit tests required now?

@iamsobanjaved
Copy link
Author

We are yet testing the upgrade on stage and already hit an issue and made fix PR for that. I think we can wait till tomorrow, until the upgrade is complete.

@kdmccormick
Copy link
Member

Sounds good, just let me know.

@iamsobanjaved
Copy link
Author

@kdmccormick it is live on the production so you can now mark Django 4.2 tests as required.

@kdmccormick
Copy link
Member

Done!

@github-project-automation github-project-automation bot moved this from Blocked to Done in Axim Engineering Tasks Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

2 participants