Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Add REQUIRED check on Ruby 3.0 CI pipeline for cs_comments_service #884

Closed
saadyousafarbi opened this issue Sep 20, 2023 · 4 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@saadyousafarbi
Copy link

saadyousafarbi commented Sep 20, 2023

Firm Name

2U

Urgency

Medium (< 2 weeks)

Requested Change

Team Infinity need to update the repo settings for cs_comments_service, and make the Ruby 3.0 CI test pipeline a required check on every PR.

Reasoning

Team Infinity recently updated the Ruby version of cs_comment_service from version 2 to 3.
This was done as Ruby 2 was EOL. We now need to enforce the Ruby 3 test build pipeline to be required for all new PRs, to be compatible with the upgraded version.
This is currently blocking ready to merge PRs, as we are waiting for this check to be required on every PR.

@saadyousafarbi saadyousafarbi added the github-request Request for change to access level or settings in the openedx GitHub organization. label Sep 20, 2023
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@brian-smith-tcril brian-smith-tcril self-assigned this Sep 20, 2023
@brian-smith-tcril
Copy link

@saadyousafarbi the build matrix does not currently include Ruby 3.1. https://github.com/openedx/cs_comments_service/blob/acc9b2f154324b02291b5b500a7f2660dec5aaa8/.github/workflows/ci.yml#L16 only has '2.5.7' and '3.0.4'

The open PR for removing ruby 2 also doesn't mention 3.1.

If you'd like I can add the 3.0.4 build as a required status check, but the workflow file will need to be updated to include 3.1 for me to add that as a required check.

@saadyousafarbi saadyousafarbi changed the title [GH Request] Add REQUIRED check on Ruby 3.1 CI pipeline for cs_comments_service [GH Request] Add REQUIRED check on Ruby 3.0 CI pipeline for cs_comments_service Sep 20, 2023
@saadyousafarbi
Copy link
Author

Sorry @brian-smith-tcril i mistyped.
We are looking to add the required check for Ruby 3.0.4.
The one that is present in the build matrix you shared.

@brian-smith-tcril
Copy link

image

It should be good to go now! If you have any issues let me know and I'll be happy to reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Done
Development

No branches or pull requests

2 participants