Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Rotate edx_smtp_username and edx_smtp_password #876

Closed
katebygrace opened this issue Sep 11, 2023 · 8 comments
Closed

[GH Request] Rotate edx_smtp_username and edx_smtp_password #876

katebygrace opened this issue Sep 11, 2023 · 8 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@katebygrace
Copy link

Firm Name

2u

Urgency

Low (2 weeks)

Requested Change

Hey there,

I'd like to rotate all IAM users in production, including openedx-smtp. I believe this is stored in your GHA secrets as edx_smtp_username / edx_smtp_password. Let me know a good place to toss the creds. Thanks!

Previous ticket for reference #842

Reasoning

Security

@katebygrace katebygrace added the github-request Request for change to access level or settings in the openedx GitHub organization. label Sep 11, 2023
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@feanil
Copy link
Contributor

feanil commented Sep 13, 2023

@katebygrace I've added a new edx_smtp_username and edx_smtp_password - Github Action Secrets record to our shared password folder, can you add the relevant credentials there and I'll update Github Actions with the new values once that's done.

@feanil feanil moved this from Backlog to In Progress in Axim Engineering Tasks Sep 13, 2023
@feanil feanil self-assigned this Sep 13, 2023
@katebygrace
Copy link
Author

Thanks @feanil ! I added the new IAM user key/secret. Feel free to add and hit me up on slack if you have any trouble!

@feanil
Copy link
Contributor

feanil commented Sep 15, 2023

@katebygrace It looks like the creds are passed strait through as the SMTP creds. Can you confirm that you've tested this and confirmed that you're getting the e-mails you're sending?

This is where the creds are used if that's helpful: https://github.com/openedx/.github/blob/3968981307ed2c11a83bf27483c2cacbe8c5f64c/.github/workflows/upgrade-python-requirements.yml#L94-L118

@feanil feanil assigned brian-smith-tcril and unassigned feanil Sep 18, 2023
@brian-smith-tcril
Copy link

@katebygrace is there more left to do on this one?

@feanil
Copy link
Contributor

feanil commented Sep 28, 2023

@brian-smith-tcril Where I left this was, we have the creds but I was waiting on confirmation that they were tested before I updated the secret in github since that's a one-way operation and we can't roll-back to the old creds.

@kdmccormick
Copy link
Member

@katebygrace , can you respond to Feanil's question above so I can update the secrets in GitHub and close this out?

@kdmccormick kdmccormick moved this from In Progress to Blocked in Axim Engineering Tasks Oct 4, 2023
@kdmccormick kdmccormick assigned bmtcril and unassigned kdmccormick Oct 16, 2023
@bmtcril
Copy link
Contributor

bmtcril commented Oct 18, 2023

Pinged Kate in Slack yesterday and also didn't hear back, so I'm closing this as stale. @feanil do you want to put a note in with those creds that they're not currently in use and point back to this ticket? I don't seem to have access to that shared password folder.

@bmtcril bmtcril closed this as completed Oct 18, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Axim Engineering Tasks Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

5 participants