Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Need write access on discoery repo to create a PR #827

Closed
Tracked by #822
jawad-khan opened this issue Jul 18, 2023 · 6 comments
Closed
Tracked by #822

[GH Request] Need write access on discoery repo to create a PR #827

jawad-khan opened this issue Jul 18, 2023 · 6 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@jawad-khan
Copy link

Firm Name

2U

Urgency

High (< 3 days)

Problem/Request

I need to create a pull request on discovery repo for some changes related to mobile work. I need write access for pushing my code on the repo.

Reasoning

We are having errors in logs for ecommerce api requests and some course authors are unable to update their courses.

@jawad-khan jawad-khan added the github-request Request for change to access level or settings in the openedx GitHub organization. label Jul 18, 2023
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@arbrandes arbrandes added the high urgency - now This is a fire. label Jul 18, 2023
@arbrandes arbrandes self-assigned this Jul 18, 2023
@arbrandes
Copy link
Contributor

@jawad-khan, I see you're already in ecommerce-maintainers, but I need confirmation from an approver other than yourself. Maybe somebody in @openedx/course-discovery-maintainers can give a thumbs up?

@zawan-ila
Copy link

Hi @jawad-khan @arbrandes, the recommended way to contribute to discovery, at least since I've been around, has been to fork the repo and push to your fork. That should not require write access.

@arbrandes
Copy link
Contributor

@zawan-ila, that's what's supposed to happen usually, yeah. @jawad-khan, is there any reason why the workflow @zawan-ila describes wouldn't work for you?

@arbrandes arbrandes added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed high urgency - now This is a fire. labels Jul 19, 2023
@jawad-khan
Copy link
Author

@zawan-ila @arbrandes
I have created a PR through fork and will post it in discovery channel, If those guys don't have any issue in merging PR through fork then it will work for me. Thanks :).

@arbrandes
Copy link
Contributor

Excellent, thank you for confirming!

@arbrandes arbrandes removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Done
Development

No branches or pull requests

3 participants