Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce CLA Check Everywhere #407

Closed
feanil opened this issue Aug 8, 2022 · 4 comments
Closed

Enforce CLA Check Everywhere #407

feanil opened this issue Aug 8, 2022 · 4 comments
Assignees

Comments

@feanil
Copy link
Contributor

feanil commented Aug 8, 2022

The CLA checks gets run by the webhooks bot on any repo it has write access to, however, the check is not always required. This means that it can be ignored even if it is failing. People can bypass the CLA check and still merge.

  • Do we want that or should we update our repos to better enforce the CLA check?

Example PR Where the CLA failed but the change was merged anyway: openedx-unsupported/configuration#6780

@feanil
Copy link
Contributor Author

feanil commented Aug 8, 2022

@e0d, @Carlos-Muniz and I noticed this while we were investigating other CLA stuff. This seems wrong but wanted to check in before we prioritized fixing it.

@nedbat
Copy link
Contributor

nedbat commented Aug 9, 2022

If we do enforce the check, it will do two things which are probably good:

  • Tool us up to make repo settings uniform across an org (or some other grouping of repos)
  • Fix onboarding problems that keep entity-covered people out of the CLA database.

@feanil
Copy link
Contributor Author

feanil commented Oct 27, 2022

I created openedx-unsupported/terraform-github#39 as a first stab at this.

@feanil
Copy link
Contributor Author

feanil commented Nov 1, 2022

We ran the script that was merged in with this PR: openedx-unsupported/terraform-github#39 We have a ticket for automating it to run regularly in the future. openedx/repo-tools#385

Closing this ticket as I think we've got leftover work tracked and the main concern here should not happen again for all the existing repos.

@feanil feanil closed this as completed Nov 1, 2022
@feanil feanil self-assigned this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants