Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] remove/re-enable static-assets-check for edx-platform in order to land a PR #1276

Closed
dianakhuang opened this issue Oct 11, 2024 · 4 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@dianakhuang
Copy link

Repository

edx-platform

Urgency

High (< 3 days)

Requested Change

In order to land the PR to fix edx-platform testing, we need to disable the static-assets-check as a required check in the branch protection rules of edx-platform, as it's pinned to ubuntu-latest: openedx/edx-platform#35635

For example:

static-assets-check (ubuntu-latest, 3.11, 18, 10.5.x, 7.0)

Once the PR has landed, we would like to enable these checks again for ubuntu-22.04.

Reasoning

The rollover to ubuntu-24.04 caused a bunch of things to be broken in our current edx-platform workflows. We want to pin to ubuntu-22.04 while we work out how to upgrade the workflows and edx.org to ubuntu-24.04. The PR has more context.

@dianakhuang dianakhuang added the github-request Request for change to access level or settings in the openedx GitHub organization. label Oct 11, 2024
@ormsbee ormsbee self-assigned this Oct 11, 2024
@ormsbee ormsbee moved this from Backlog to In Progress in Axim Engineering Tasks Oct 11, 2024
@ormsbee
Copy link

ormsbee commented Oct 11, 2024

I removed the two status-assets-check checks from the branch protection rules for master on edx-platform.

assets-checks

@ormsbee
Copy link

ormsbee commented Oct 11, 2024

FYI @feanil as this is related to targeting ubuntu-latest.

Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@ormsbee
Copy link

ormsbee commented Oct 11, 2024

I removed the status checks at around 9:56 EDT and put ubuntu-22.04 versions of them back in place at about 11:03 EDT.

Image

@ormsbee ormsbee closed this as completed Oct 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Axim Engineering Tasks Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

2 participants