Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Remove Code Owner Restriction on 2 Repos #1113

Closed
feanil opened this issue Apr 10, 2024 · 3 comments
Closed

[GH Request] Remove Code Owner Restriction on 2 Repos #1113

feanil opened this issue Apr 10, 2024 · 3 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@feanil
Copy link
Contributor

feanil commented Apr 10, 2024

Repository

axim-engineering

Urgency

Low (2 weeks)

Requested Change

The frontend-app-payment and frontend-app-ecommerce repos should no longer have any 2U specific merge restrictions.

Reasoning

The frontend-app-payment and frontend-app-ecommerce repositories are no longer being maintained by 2U and they have their own forks (See attached Image). We no longer need to have 2U specific code-owner restrictions on these repos for SOX compliance.

image

@feanil feanil added the github-request Request for change to access level or settings in the openedx GitHub organization. label Apr 10, 2024
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@feanil feanil self-assigned this Apr 10, 2024
@christopappas
Copy link

Hey there @feanil I've created the following PRs:

Payment MFE PR: openedx-unsupported/frontend-app-payment#867
Ecommerce MFE PR: openedx-unsupported/frontend-app-ecommerce#380

Let me know if this was not what you had in mind.

Thanks!

@feanil
Copy link
Contributor Author

feanil commented Apr 11, 2024

Thanks @christopappas, those looked good and I've merged them. I've also removed the restriction that codeowner based approval is needed to merge and the restriction that only the revenue squad can merge to master on these repos. This should be all set.

@feanil feanil closed this as completed Apr 11, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Axim Engineering Tasks Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

2 participants