Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Cannot merge PRs. CodeCov uploads failing despite retries #1109

Closed
jesperhodge opened this issue Apr 9, 2024 · 12 comments
Closed
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@jesperhodge
Copy link
Member

Firm Name

2U

Urgency

High (< 3 days)

Problem/Request

It looks like pipelines are failing across different PRs and different repos (course-authoring MFE, learning MFE) due to inability to upload to CodeCov. I know in the past retrying solved this, but I retried 10 times now on my PR and it didn't fix this.
Here's some examples:

Could you look into this?

Reasoning

This blocks our ability to merge PRs

@jesperhodge jesperhodge added the github-request Request for change to access level or settings in the openedx GitHub organization. label Apr 9, 2024
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@sarina
Copy link
Contributor

sarina commented Apr 9, 2024

Hi @jesperhodge - this is related to a change that Codecov made regarding per-repo tokens. @feanil and @brian-smith-tcril are going to take the lead on figuring out how we're going to address this. Apologies that this is happening.

@jesperhodge
Copy link
Member Author

Thanks for looking into it!

@mariajgrimaldi
Copy link
Member

Hi folks. Should we move to python-coverage-comment-action? Or are there more advantages to using the codecov service? There might be use cases that I'm missing though. A few weeks ago I picked up the work Ned started for the replacement: openedx/openedx-events#323

@feanil
Copy link
Contributor

feanil commented Apr 11, 2024

@mariajgrimaldi @brian-smith-tcril pointed out that codecov has support for JS which the alternative that we are looking at does not support, so we may need to do more research before we can move off of codecov.

@feanil
Copy link
Contributor

feanil commented Apr 11, 2024

@jesperhodge This should be fixed once openedx/frontend-app-authoring#950 and openedx/frontend-app-learning#1351 land, can you please review and feel free to merge if they look good to you.

@mariajgrimaldi
Copy link
Member

@feanil: is that secret common to all openedx repositories? Or do we have to set it up manually? I tried updating codecov here but it didn't work:
https://github.com/openedx/openedx-events/actions/runs/8662684410/job/23755234691?pr=339

@feanil
Copy link
Contributor

feanil commented Apr 12, 2024

@mariajgrimaldi annoyingly it is per repository, I've added the scertes for openedx-events and filters as well to unblock that codecov update over there if you want to make the github actions updates on those repos.

@DawoudSheraz
Copy link

The job is failing for edx-val as well openedx/edx-val#496. I followed openedx/i18n-tools@939d4e3 but as @feanil mentioned, it seems the token would need to be configured for each repository separately.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Apr 15, 2024

@feanil
Copy link
Contributor

feanil commented Apr 16, 2024

edx-ora2 and edx-val have both been updated with the new tokens.

PR for edx-ora2 to update the workflow: openedx/edx-ora2#2206

@feanil
Copy link
Contributor

feanil commented Apr 16, 2024

The relevant PRs for the original request have merged so this is all set. If we find more repos with the same issue, please create new requests and we'll update the repos with tokens.

@feanil feanil closed this as completed Apr 16, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Axim Engineering Tasks Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

6 participants