Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Allow edx-transifex-bot to merge to frontend-component-ai-translations #1012

Closed
hajorg opened this issue Jan 3, 2024 · 10 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@hajorg
Copy link

hajorg commented Jan 3, 2024

Firm Name

2U

Urgency

Medium (< 2 weeks)

Requested Change

We would like the edx-transifex-bot to be able to create/merge its own PRs into frontend-component-ai-translations.

Reasoning

There is a Jenkins job that creates i18n translations PRs but the job fails with the error message below whenever edx-transifex-bot tries to create a PR in the repo
remote: Permission to openedx/frontend-component-ai-translations.git denied to edx-transifex-bot. fatal: unable to access 'https://github.com/openedx/frontend-component-ai-translations.git/': The requested URL returned error: 403

@hajorg hajorg added the github-request Request for change to access level or settings in the openedx GitHub organization. label Jan 3, 2024
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@feanil
Copy link
Contributor

feanil commented Jan 3, 2024

@OmarIthawi @brian-smith-tcril does it make sense to set up this new repo with the new OEP-58 tooling to begin with rather than with the old jenkins tooling internal to 2U?

@feanil feanil self-assigned this Jan 3, 2024
@brian-smith-tcril
Copy link

l does it make sense to set up this new repo with the new OEP-58 tooling to begin with rather than with the old jenkins tooling internal to 2U?

Yes. We should not be setting up edx-transifex-bot on new repos (first commit is from Oct 18, 2023). @hajorg was there documentation you were following that recommended this? I'd like to make sure any docs recommending this are updated to point to https://docs.openedx.org/en/latest/developers/how-tos/enable-translations-new-repo.html

@hajorg
Copy link
Author

hajorg commented Jan 4, 2024

l does it make sense to set up this new repo with the new OEP-58 tooling to begin with rather than with the old jenkins tooling internal to 2U?

Yes. We should not be setting up edx-transifex-bot on new repos (first commit is from Oct 18, 2023). @hajorg was there documentation you were following that recommended this? I'd like to make sure any docs recommending this are updated to point to https://docs.openedx.org/en/latest/developers/how-tos/enable-translations-new-repo.html

Hi @brian-smith-tcril, https://github.com/openedx/frontend-platform/blob/master/docs/how_tos/i18n.rst is the documentation I was following for the setup. I wasn't aware there is another way of achieving translations.

@hajorg
Copy link
Author

hajorg commented Jan 9, 2024

Hi, I forked https://github.com/openedx/openedx-translations and created a PR hajorg/openedx-translations#1 following the steps outlined in https://docs.openedx.org/en/latest/developers/how-tos/enable-translations-new-repo.html#id7 but CI seems to be failing. It seems as though I might need an env variable. Can someone help verify if I’m doing the right thing and what I need to do to resolve the issue.

cc @brian-smith-tcril @feanil

@brian-smith-tcril
Copy link

@hajorg the GH_TOKEN error here is coming from here

        env:
          # This token requires Write access to the openedx-translations repo
          GITHUB_TOKEN: ${{ secrets.EDX_TRANSIFEX_BOT_GITHUB_TOKEN }}

I would not worry about that step failing on your fork, the branch created by the action seems to have a valid transifex_input.json file in the frontend-component-ai-translations directory, which is more than enough to verify things are working as expected without merging into your fork's main branch.

@hajorg
Copy link
Author

hajorg commented Jan 9, 2024

@hajorg the GH_TOKEN error here is coming from here

        env:
          # This token requires Write access to the openedx-translations repo
          GITHUB_TOKEN: ${{ secrets.EDX_TRANSIFEX_BOT_GITHUB_TOKEN }}

I would not worry about that step failing on your fork, the branch created by the action seems to have a valid transifex_input.json file in the frontend-component-ai-translations directory, which is more than enough to verify things are working as expected without merging into your fork's main branch.

Got it. Thanks @brian-smith-tcril. This means I can create a PR against https://github.com/openedx/openedx-translations, right?

@brian-smith-tcril
Copy link

Got it. Thanks @brian-smith-tcril. This means I can create a PR against https://github.com/openedx/openedx-translations, right?

@hajorg Yes!

@feanil
Copy link
Contributor

feanil commented Jan 11, 2024

Ok, it sounds like you have what you need @hajorg , is there anything else you need before I close this ticket?

@hajorg
Copy link
Author

hajorg commented Jan 12, 2024

Ok, it sounds like you have what you need @hajorg , is there anything else you need before I close this ticket?

@feanil , thank you for your help. This can be closed.

@feanil feanil closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Done
Development

No branches or pull requests

3 participants