Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tox<4.0.0 to constraints.txt #233

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore: Add tox<4.0.0 to constraints.txt #233

merged 1 commit into from
Oct 23, 2023

Conversation

ZiqiXiao
Copy link
Contributor

@ZiqiXiao ZiqiXiao commented Oct 19, 2023

Add tox<4.0.0 to containts.txt for public-engineering#217

Reviewers:

Add tox<4.0.0 to containts.txt for public-engineering#217
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 19, 2023

Thanks for the pull request, @ZiqiXiao! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 19, 2023
@feanil
Copy link
Contributor

feanil commented Oct 19, 2023

@ZiqiXiao the change looks pretty reasonable, but we need you to sign the CLA. Please let me know once you've completed that work. Usually it takes about 24h on our side to process a CLA.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 19, 2023
@ZiqiXiao
Copy link
Contributor Author

ZiqiXiao commented Oct 20, 2023

@ZiqiXiao the change looks pretty reasonable, but we need you to sign the CLA. Please let me know once you've completed that work. Usually it takes about 24h on our side to process a CLA.

@feanil I have signed the CLA and it's been processed. I think I am ready.

@feanil feanil changed the title chore: Add tox<4.0.0 to containts.txt chore: Add tox<4.0.0 to constraints.txt Oct 23, 2023
@feanil feanil merged commit e042bce into openedx:master Oct 23, 2023
6 checks passed
@openedx-webhooks
Copy link

@ZiqiXiao 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants