Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade to Django 4.2 #217

Merged
merged 2 commits into from
Jul 21, 2023
Merged

feat: Upgrade to Django 4.2 #217

merged 2 commits into from
Jul 21, 2023

Conversation

zubairshakoorarbisoft
Copy link
Contributor

@zubairshakoorarbisoft zubairshakoorarbisoft commented Jul 17, 2023 •
edited
Loading

Link to JIRA ticket
Upgrade to Django 4.2
Dependencies: dependencies on other outstanding PRs, issues, etc.

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

UsamaSadiq
UsamaSadiq approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump version to 1.7.0 and add a new section in the CHANGELOG before merging.

@zubairshakoorarbisoft
Copy link
Contributor Author

Please bump version to 1.7.0 and add a new section in the CHANGELOG before merging.

done

@zubairshakoorarbisoft zubairshakoorarbisoft merged commit d2674f8 into master Jul 21, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft deleted the zshkoor/django42 branch July 21, 2023 12:19
@zubairshakoorarbisoft zubairshakoorarbisoft changed the title feat: upgrade to django 4.2 feat: Upgrade to Django 4.2 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

@awais786 awais786 awais786 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zubairshakoorarbisoft @awais786 @UsamaSadiq