Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acid-block | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #187

Merged
merged 4 commits into from
Oct 1, 2024
Merged

acid-block | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #187

merged 4 commits into from
Oct 1, 2024

Conversation

ttqureshi
Copy link
Contributor

@ttqureshi ttqureshi commented Sep 25, 2024 •
edited
Loading

Overview

This PR:

  • replaces pkg_resources api from importlib_resources api
  • drops support for python 3.8 and add support for python 3.11

Tickets:

Followed this migration guide.

Testing

I have tested the changes against the following steps:

  • Install the acid-block to xblock-sdk.
  • Functional testing

Screenshots

XBlock Acid single block test

image

XBlock Acid Parent test

image

@ttqureshi
chore: Replace pkg_resources lib with importlib.resources
d4e4cda 
- transitioned from pkg_resources api to importlib-resources api
@ttqureshi
chore: Drop support for Python 3.8
d586599 
- Drop support for python 3.8 and add support for python 3.11 and 3.12
farhan
farhan suggested changes Sep 27, 2024
View reviewed changes
Copy link

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change

acid/acid.py Outdated Show resolved Hide resolved
feanil
feanil approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version so we can also do a new release.

@ttqureshi
Copy link
Contributor Author

Please bump the version so we can also do a new release.

ok 👍

@feanil feanil merged commit ad2eb13 into openedx:master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan farhan farhan approved these changes

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 3.8 & Add Support for Python 3.12 Move on from deprecated pkg_resources api
3 participants
@ttqureshi @feanil @farhan