Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component is not being created in Redwood #87

Open
mariajgrimaldi opened this issue May 23, 2024 · 13 comments
Open

Component is not being created in Redwood #87

mariajgrimaldi opened this issue May 23, 2024 · 13 comments
Labels
bug Report of or fix for something that isn't working as intended release testing Affects the upcoming release (attention needed)

Comments

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 23, 2024

Expected behavior

Recommender xblock should be created.

Actual behavior

When a recommender component is added nothing happens. When the page is refreshed on studio the page won't load. From LMS an error is displayed.

You can see it here (until next Monday): https://studio.redwood.demo.edly.io/container/block-v1:OpenedX+DemoX+DemoCourse+type@vertical+block@19fc1913a7f64ce4a4223e9f314cedef

Screencast.from.23-05-24.09.51.20.webm

Steps to reproduce

Go to Studio, add "recommender" to "Advanced Settings" -> "Advanced module list" add a component from "Advanced" -> "recommender"

Original issue: openedx/wg-build-test-release#355

@mariajgrimaldi
Copy link
Member Author

Hi @navinkarkera! I see you're the new maintainer. Could you give us a hand here? Thanks!

@mariajgrimaldi mariajgrimaldi added the release testing Affects the upcoming release (attention needed) label May 23, 2024
@navinkarkera
Copy link
Contributor

@mariajgrimaldi I don't have write access yet as I just closed the nomination post. I'll need to sort out the permissions first, but I can take a look in the meantime.

@mariajgrimaldi mariajgrimaldi added the bug Report of or fix for something that isn't working as intended label May 24, 2024
@navinkarkera
Copy link
Contributor

@mariajgrimaldi I just tried this xblock on tutor-nightly and it seems to work, although it doesn't look very good. I am not sure if I can get redwood stack working locally via tutor as of now.

image

@mariajgrimaldi
Copy link
Member Author

Thank you for trying it! Was that tutor-nightly a remote environment? I'm just making sure the error is not related to an asset-production issue.

@navinkarkera
Copy link
Contributor

Was that tutor-nightly a remote environment?

@mariajgrimaldi No, tested it locally.

@mariajgrimaldi
Copy link
Member Author

@navinkarkera: I tested it locally on Redwood, and it worked. So this might be related to how it's being deployed, maybe to the assets-building process? I don't know this component so I couldn't say for sure, but this is the error I'm seeing in the Studio console after replicating what I mentioned above:

Uncaught SyntaxError: invalid regular expression flag t
    globalEval https://studio.redwood.demo.edly.io/static/studio/js/cms-base-vendor.5fa9e818ccd4.js:486
    domManip https://studio.redwood.demo.edly.io/static/studio/js/cms-base-vendor.5fa9e818ccd4.js:5434
    append https://studio.redwood.demo.edly.io/static/studio/js/cms-base-vendor.5fa9e818ccd4.js:5574
    loadResource https://studio.redwood.demo.edly.io/static/studio/bundles/js/factories/container.33125aa522f51f597b81.ab77e4b3456f.js:2
    i https://studio.redwood.demo.edly.io/static/studio/bundles/js/factories/container.33125aa522f51f597b81.ab77e4b3456f.js:2
    i https://studio.redwood.demo.edly.io/static/studio/bundles/js/factories/container.33125aa522f51f597b81.ab77e4b3456f.js:2
    fire https://studio.redwood.demo.edly.io/static/studio/js/cms-base-vendor.5fa9e818ccd4.js:3330
    add https://studio.redwood.demo.edly.io/static/studio/js/cms-base-vendor.5fa9e818ccd4.js:3389

@navinkarkera
Copy link
Contributor

@mariajgrimaldi It might be due underscore.min.js file as that is the only file which has regex with t flag which according to mozilla is not a valid flag (I am not even sure that is the issue here but doesn't hurt to try). The use of underscore.min.js was removed via this commit: 40bd60d so it should be safe to remove the file completely.

@navinkarkera
Copy link
Contributor

@mariajgrimaldi Were you able to get this working?

@mariajgrimaldi
Copy link
Member Author

@navinkarkera: thank you for all the insight. I haven't had the time to review this, but I'll try to get someone from my team to look. Thank you!

@BryanttV
Copy link

Hi @mariajgrimaldi @navinkarkera, I'm working on this issue. I will first try deleting the file that may be causing the error.

@BryanttV
Copy link

I tested in a remote environment on Redwood (18.1.2). I installed a custom version that doesn't include the underscore.min.js file. However, it still keeps the same error, and this comes up in the browser console:

VM591:1 Uncaught SyntaxError: Invalid regular expression flags
    at eval (<anonymous>)
    at Function.globalEval (cms-base-vendor.5fa9e818ccd4.js:486:5)
    at domManip (cms-base-vendor.5fa9e818ccd4.js:5434:15)
    at jQuery.fn.init.append (cms-base-vendor.5fa9e818ccd4.js:5574:10)
    at child.loadResource (container.33125aa522f51f597b81.ab77e4b3456f.js:2:97554)
    at i (container.33125aa522f51f597b81.ab77e4b3456f.js:2:97120)
    at Object.<anonymous> (container.33125aa522f51f597b81.ab77e4b3456f.js:2:97192)
    at fire (cms-base-vendor.5fa9e818ccd4.js:3330:31)
    at Object.add [as done] (cms-base-vendor.5fa9e818ccd4.js:3389:7)
    at i (container.33125aa522f51f597b81.ab77e4b3456f.js:2:97175)

I will continue to investigate what may be causing the error.

@BryanttV
Copy link

Hi, sorry for not updating the status of this. I spent some more time researching and found the following:

  1. For Redwood (v18.1.2) on local and remote with this branch which removes the underscore.min.js file from XBlock, the same error also happens.
  2. For Nightly and v2.2.0 of XBlock, it works correctly locally.
  3. Finally, with Redwood (v18.1.3 and v18.1.2) I tried an edx-platform mount with the master branch, and it works.

As a conclusion, the problem seems to be directly in edx-platform. In the master branch it seems to be already fixed.

@navinkarkera
Copy link
Contributor

@BryanttV Thank you for you investigation!

@mariajgrimaldi Should we close this issue now that it has been fixed in master branch of edx-platform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended release testing Affects the upcoming release (attention needed)
Projects
Status: Backlog
Development

No branches or pull requests

3 participants