This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add Django 4.2 support in CI in Registrar #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irtazaakram
force-pushed
the
add-django42
branch
3 times, most recently
from
e845934
to
a50d340
Compare
UsamaSadiq
reviewed
Sep 28, 2023
irtazaakram
force-pushed
the
add-django42
branch
from
a6f6706
to
02c1546
Compare
irtazaakram
force-pushed
the
add-django42
branch
from
bb8d030
to
e103b33
Compare
…ls due to cache issue.
awais786
reviewed
Oct 5, 2023
| commands = {posargs:pytest} | ||
| setenv = |
There was a problem hiding this comment.
Tox gives error locally due to boto issue.
awais786
changed the title
Zacharis278
reviewed
Oct 6, 2023
|
@Zacharis278 you can review this again. |
UsamaSadiq
approved these changes
Oct 9, 2023
UsamaSadiq
reviewed
Oct 9, 2023
| @@ -14,6 +14,8 @@ | |||
|
|
|||
| from ..api_client import DISCOVERY_API_TPL, DiscoveryServiceClient | |||
| from ..discovery_cache import ProgramDetails | |||
| from ..tests.test_api_client import \ | |||
There was a problem hiding this comment.
Why is this change needed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description