Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Feature: Support for FAISS JNI #286

Closed
luyuncheng opened this issue Dec 25, 2020 · 1 comment
Closed

Feature: Support for FAISS JNI #286

luyuncheng opened this issue Dec 25, 2020 · 1 comment

Comments

@luyuncheng
Copy link

*As Issue #225 mentioned. It is possible to support faiss as future.

But i do not implement the codec services, because i want to ask for your opinions about this part.
I prefer to use the same interface(saveIndex, init, queryIndex) as same as nmslib's code with the same input parameter. so i do PR #285
i think with the same interface we can support nmslib and faiss in knn plugin at the same time.

Description of changes:

  1. This PR is support Faiss index and Query with the same interface in jni code.
  2. In KNNJNIFaissTests tests, it can do the same logic as KNNIndex and KNNJNITests
  3. We can modified interface code as less as mush.
  4. To build this, we need to build faiss firstly which depends on some external Libs like OpenMP,BLAS etc.
  5. Is there any possible to open a faiss branch?
@jmazanec15
Copy link
Member

For this feature, we will be tracking in #225

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants