From fec030e399f60f0240c24076b4e12e90092d66a6 Mon Sep 17 00:00:00 2001
From: Etienne Burdet <etienne.burdet@hey.com>
Date: Tue, 12 Nov 2024 16:21:05 +0100
Subject: [PATCH] =?UTF-8?q?feat:=C2=A0add=20clickable=20and=20hoverable=20?=
 =?UTF-8?q?rows=20to=20table?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../stories/Table/Table.stories.tsx           | 30 ++++++++++-
 .../src/components/Table/Body.svelte          | 19 ++-----
 .../src/components/Table/Cell/Cell.svelte     | 54 +++++++++++++++++--
 .../src/components/Table/Cell/ZoomIcon.svelte | 15 ++++++
 .../src/components/Table/Row.svelte           | 52 ++++++++++++++++++
 .../src/components/Table/Table.svelte         |  6 +--
 .../src/components/Table/TableCard.svelte     |  3 +-
 .../src/components/Table/types.ts             |  7 +++
 8 files changed, 164 insertions(+), 22 deletions(-)
 create mode 100644 packages/visualizations/src/components/Table/Cell/ZoomIcon.svelte
 create mode 100644 packages/visualizations/src/components/Table/Row.svelte

diff --git a/packages/visualizations-react/stories/Table/Table.stories.tsx b/packages/visualizations-react/stories/Table/Table.stories.tsx
index d64a1050..3abe61bc 100644
--- a/packages/visualizations-react/stories/Table/Table.stories.tsx
+++ b/packages/visualizations-react/stories/Table/Table.stories.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useState } from 'react';
 import { ComponentMeta, ComponentStory } from '@storybook/react';
 import type { TableData, Async } from '@opendatasoft/visualizations';
 
@@ -39,6 +39,28 @@ const ScrollTemplate: ComponentStory<typeof Table> = args => (
     </div>
 );
 
+const RowHoverTemplate: ComponentStory<typeof Table> = args => {
+    const { options: argOptions, data: argData } = args;
+    const [hoveredRecord, setHovered] = useState<Record<string, unknown> | undefined | null>(null);
+    const [lastClicked, setLastClicked] = useState<Record<string, unknown> | undefined | null>(null);
+
+    const onMouseEnter = (record?: Record<string, unknown>) => {setHovered(record);};
+    const onMouseLeave = () => {setHovered(null);};
+    const onClick = (record?: Record<string, unknown>) => {setLastClicked(record);};
+
+    return (
+        <>
+        <h3>Hovered</h3>
+        <pre>{JSON.stringify(hoveredRecord)}</pre>
+        <h3>Clicked</h3>
+        <pre>{JSON.stringify(lastClicked)}</pre>
+            <div style={{ maxWidth: '800px' }}>
+                <Table data={argData} options={{...argOptions, rows: { onClick, onMouseEnter, onMouseLeave}}}/>
+            </div>;
+        </>
+    );
+};
+
 const optionsWithPagination = {
     ...options,
     pagination: {
@@ -107,3 +129,9 @@ RtlDirection.args = {
     data,
     options: optionsWithPagination,
 };
+
+export const Rows = RowHoverTemplate.bind({});
+Rows.args = {
+    data,
+    options,
+};
diff --git a/packages/visualizations/src/components/Table/Body.svelte b/packages/visualizations/src/components/Table/Body.svelte
index e3c97202..85c77eb6 100644
--- a/packages/visualizations/src/components/Table/Body.svelte
+++ b/packages/visualizations/src/components/Table/Body.svelte
@@ -1,10 +1,12 @@
 <script lang="ts">
-    import type { Column, TableData } from './types';
-    import Cell, { LoadingCell } from './Cell';
+    import type { Column, Rows, TableData } from './types';
+    import { LoadingCell } from './Cell';
     import EmptyRow from './EmptyRow.svelte';
+    import Row from './Row.svelte';
 
     export let loadingRowsNumber: number | null;
     export let columns: Column[];
+    export let rows: Rows | undefined;
     export let records: TableData | undefined;
     export let emptyStateLabel: string | undefined;
 </script>
@@ -23,21 +25,10 @@
         {/each}
     {:else if records}
         {#each records as record}
-            <tr>
-                {#each columns as column}
-                    <Cell rawValue={record[column.key]} {column} />
-                {/each}
-            </tr>
+            <Row {columns} {rows} {record} />
         {/each}
     {/if}
 </tbody>
 
 <style>
-    :global(.ods-dataviz--default) tr {
-        border-bottom: 1px solid var(--border-color);
-    }
-
-    :global(.ods-dataviz--default) tr:last-child {
-        border-bottom: none;
-    }
 </style>
diff --git a/packages/visualizations/src/components/Table/Cell/Cell.svelte b/packages/visualizations/src/components/Table/Cell/Cell.svelte
index f501ce3d..f421f716 100644
--- a/packages/visualizations/src/components/Table/Cell/Cell.svelte
+++ b/packages/visualizations/src/components/Table/Cell/Cell.svelte
@@ -1,21 +1,44 @@
 <script lang="ts">
     import type { Column } from '../types';
     import Format, { isValidRawValue } from './Format';
+    import ZoomIcon from './ZoomIcon.svelte';
 
     export let rawValue: unknown;
     export let column: Column;
+    export let onClick: (() => void) | null;
+    export let isRowHovered = false;
 
     $: ({ dataFormat, options = {} } = column);
 </script>
 
 <!-- To display a format value, rawValue must be different from undefined or null -->
 <td class={`table-data--${dataFormat}`}>
-    {#if isValidRawValue(rawValue)}
-        <svelte:component this={Format[dataFormat]} {rawValue} {...options} />
-    {/if}
+    <div class="cell-wrapper">
+        {#if onClick}
+            <button on:click={onClick} class:visible={isRowHovered}>
+                <ZoomIcon />
+            </button>
+        {/if}
+        <div class="value-container">
+            {#if isValidRawValue(rawValue)}
+                <svelte:component this={Format[dataFormat]} {rawValue} {...options} />
+            {/if}
+        </div>
+    </div>
 </td>
 
 <style>
+    .cell-wrapper {
+        display: flex;
+        justify-content: space-between;
+        align-items: center;
+        padding-right: 6px;
+    }
+    .value-container {
+        flex-shrink: 1;
+        overflow: hidden;
+        text-overflow: ellipsis;
+    }
     :global(.ods-dataviz--default td) {
         padding: var(--spacing-75);
     }
@@ -43,4 +66,29 @@
     :global(.ods-dataviz--default td.table-data--number) {
         text-align: right;
     }
+
+    :global(.ods-dataviz--default) button {
+        background-color: transparent;
+        color: #142e7b;
+        border-radius: 50%;
+        height: 28px;
+        width: 28px;
+        margin-right: 3px;
+        padding: 6px;
+        border: none;
+        box-shadow: none;
+        display: flex;
+        justify-content: center;
+        align-items: center;
+        visibility: hidden;
+    }
+
+    :global(.ods-dataviz--default) button:hover {
+        background-color: #e2e6ee;
+        cursor: pointer;
+    }
+
+    :global(.ods-dataviz--default) button.visible {
+        visibility: visible;
+    }
 </style>
diff --git a/packages/visualizations/src/components/Table/Cell/ZoomIcon.svelte b/packages/visualizations/src/components/Table/Cell/ZoomIcon.svelte
new file mode 100644
index 00000000..bcbc7d88
--- /dev/null
+++ b/packages/visualizations/src/components/Table/Cell/ZoomIcon.svelte
@@ -0,0 +1,15 @@
+<script lang="ts">
+</script>
+
+<!-- eslint-disable max-len -->
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="currentColor">
+    <path
+        d="M18.031 16.6168L22.3137 20.8995L20.8995 22.3137L16.6168 18.031C15.0769 19.263 13.124 20 11 20C6.032 20 2 15.968 2 11C2 6.032 6.032 2 11 2C15.968 2 20 6.032 20 11C20 13.124 19.263 15.0769 18.031 16.6168ZM16.0247 15.8748C17.2475 14.6146 18 12.8956 18 11C18 7.1325 14.8675 4 11 4C7.1325 4 4 7.1325 4 11C4 14.8675 7.1325 18 11 18C12.8956 18 14.6146 17.2475 15.8748 16.0247L16.0247 15.8748ZM10 10V7H12V10H15V12H12V15H10V12H7V10H10Z"
+    />
+</svg>
+
+<style>
+    path {
+        color: currentColor;
+    }
+</style>
diff --git a/packages/visualizations/src/components/Table/Row.svelte b/packages/visualizations/src/components/Table/Row.svelte
new file mode 100644
index 00000000..b5179f28
--- /dev/null
+++ b/packages/visualizations/src/components/Table/Row.svelte
@@ -0,0 +1,52 @@
+<script lang="ts">
+    import Cell from './Cell';
+    import type { Column, Rows } from './types';
+
+    export let columns: Column[];
+    export let rows: Rows | undefined;
+    export let record: Record<string, unknown>;
+    let isRowHovered = false;
+
+    $: onMouseEnter = () => {
+        if (rows?.onMouseEnter) {
+            rows.onMouseEnter(record);
+        }
+        isRowHovered = true;
+    };
+
+    $: onMouseLeave = () => {
+        if (rows?.onMouseLeave) {
+            rows.onMouseLeave(record);
+        }
+        isRowHovered = false;
+    };
+
+    $: onClick = () => {
+        if (rows?.onClick) {
+            rows.onClick(record);
+        }
+    };
+</script>
+
+<tr on:mouseenter={onMouseEnter} on:mouseleave={onMouseLeave}>
+    {#each columns as column, index}
+        <Cell
+            rawValue={record[column.key]}
+            {column}
+            onClick={index === 0 && rows?.onClick ? onClick : null}
+            {isRowHovered}
+        />
+    {/each}
+</tr>
+
+<!-- markup (zero or more items) goes here -->
+
+<style>
+    :global(.ods-dataviz--default) tr {
+        border-bottom: 1px solid var(--border-color);
+    }
+
+    :global(.ods-dataviz--default) tr:last-child {
+        border-bottom: none;
+    }
+</style>
diff --git a/packages/visualizations/src/components/Table/Table.svelte b/packages/visualizations/src/components/Table/Table.svelte
index 352ccda8..2da7999a 100644
--- a/packages/visualizations/src/components/Table/Table.svelte
+++ b/packages/visualizations/src/components/Table/Table.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
     import type { DataFrame } from 'types';
     import { generateId } from 'components/utils';
-    import type { Column } from './types';
+    import type { Column, Rows } from './types';
     import Headers from './Headers';
     import Body from './Body.svelte';
 
@@ -10,14 +10,14 @@
     export let records: DataFrame | undefined;
     export let description: string | undefined;
     export let emptyStateLabel: string | undefined;
-
+    export let rows: Rows | undefined;
     const tableId = `table-${generateId()}`;
 </script>
 
 <div class="scrollbox">
     <table aria-describedby={description ? tableId : undefined}>
         <Headers {columns} />
-        <Body {loadingRowsNumber} {records} {columns} {emptyStateLabel} />
+        <Body {loadingRowsNumber} {records} {columns} {rows} {emptyStateLabel} />
     </table>
 </div>
 {#if description}
diff --git a/packages/visualizations/src/components/Table/TableCard.svelte b/packages/visualizations/src/components/Table/TableCard.svelte
index 254c94b2..fabb007a 100644
--- a/packages/visualizations/src/components/Table/TableCard.svelte
+++ b/packages/visualizations/src/components/Table/TableCard.svelte
@@ -14,6 +14,7 @@
     $: ({ value: records, loading: isLoading } = data);
     $: ({
         columns,
+        rows,
         title,
         subtitle,
         description,
@@ -33,7 +34,7 @@
 
 <Card {title} {subtitle} {source} defaultStyle={!unstyled}>
     <div class="table-container">
-        <Table {loadingRowsNumber} {records} {columns} {description} {emptyStateLabel} />
+        <Table {loadingRowsNumber} {records} {columns} {description} {emptyStateLabel} {rows} />
         {#if pagination}
             <Pagination {...pagination} />
         {/if}
diff --git a/packages/visualizations/src/components/Table/types.ts b/packages/visualizations/src/components/Table/types.ts
index 823c2ee8..dafac9bb 100644
--- a/packages/visualizations/src/components/Table/types.ts
+++ b/packages/visualizations/src/components/Table/types.ts
@@ -95,6 +95,12 @@ export type GeoColumn = BaseColumn & {
     }>;
 };
 
+export type Rows = {
+    onClick?: (record?: Record<string, unknown>, index?: number) => void;
+    onMouseEnter?: (record?: Record<string, unknown>, index?: number) => void;
+    onMouseLeave?: (record?: Record<string, unknown>, index?: number) => void;
+};
+
 export type Column =
     | ShortTextColumn
     | LongTextColumn
@@ -106,6 +112,7 @@ export type Column =
 
 export type TableOptions = {
     columns: Column[];
+    rows?: Rows;
     title?: string;
     subtitle?: string;
     description?: string;