From 2f2b66328c3de126055057a95dd42de816b4c220 Mon Sep 17 00:00:00 2001 From: Kevin Fabre <117300300+KevinFabre-ods@users.noreply.github.com> Date: Fri, 12 Jul 2024 10:56:40 +0200 Subject: [PATCH] chore: update github-actions (#255) remove Node matrix and use latest versions for actions --- .github/workflows/api-client.yml | 19 +++++++----------- .github/workflows/visualizations.yml | 20 ++++++++----------- .../stories/Table/Table.stories.tsx | 2 +- 3 files changed, 16 insertions(+), 25 deletions(-) diff --git a/.github/workflows/api-client.yml b/.github/workflows/api-client.yml index d6a2f462..ebdb77ec 100644 --- a/.github/workflows/api-client.yml +++ b/.github/workflows/api-client.yml @@ -8,22 +8,17 @@ on: - main jobs: build: - name: Get api client test coverage on node ${{ matrix.node }} and ${{ matrix.os }} - - runs-on: ${{ matrix.os }} - strategy: - matrix: - node: ["18.x", "20.x"] - os: [ubuntu-latest] + name: Get api client test coverage + runs-on: ubuntu-latest steps: - name: Checkout repo - uses: actions/checkout@v2 + uses: actions/checkout@v4 - - name: Use Node ${{ matrix.node }} - uses: actions/setup-node@v1 + - name: Use Node 20 + uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node }} + node-version: '20.x' - name: Install run: npm ci @@ -38,7 +33,7 @@ jobs: working-directory: ./packages/api-client - name: Comment - uses: romeovs/lcov-reporter-action@v0.2.19 + uses: romeovs/lcov-reporter-action@v0.4.0 with: github-token: ${{ secrets.GITHUB_TOKEN }} lcov-file: ./packages/api-client/coverage/lcov.info diff --git a/.github/workflows/visualizations.yml b/.github/workflows/visualizations.yml index 7b41753b..c8494fdf 100644 --- a/.github/workflows/visualizations.yml +++ b/.github/workflows/visualizations.yml @@ -25,10 +25,10 @@ jobs: steps: - name: Checkout repo - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Use Node ${{ matrix.node }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} @@ -49,10 +49,10 @@ jobs: steps: - name: Checkout repo - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Use Node ${{ matrix.node }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} @@ -65,22 +65,18 @@ jobs: chromatic-deployment: if: github.event.pull_request.draft == false || github.ref_name == 'main' runs-on: ubuntu-latest - strategy: - matrix: - node: ["18.x", "20.x"] - needs: [test, lint] steps: - name: Checkout repo - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: fetch-depth: 0 - - name: Use Node ${{ matrix.node }} - uses: actions/setup-node@v1 + - name: Use Node 20 + uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node }} + node-version: '20.x' - name: Build run: npm run build-ci diff --git a/packages/visualizations-react/stories/Table/Table.stories.tsx b/packages/visualizations-react/stories/Table/Table.stories.tsx index 27bd08c1..d64a1050 100644 --- a/packages/visualizations-react/stories/Table/Table.stories.tsx +++ b/packages/visualizations-react/stories/Table/Table.stories.tsx @@ -101,7 +101,7 @@ emptyState.args = { export const RtlDirection = Template.bind({}); RtlDirection.parameters = { direction: 'rtl', - disableSnapshot: true, + chromatic: { disableSnapshot: true }, }; RtlDirection.args = { data,