Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ACM to manage pipelines in the demo namespace on the core cluster #73

Open
grdryn opened this issue Sep 12, 2023 · 5 comments
Open
Labels
kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/high Important issue that needs to be resolved asap. Releases should not have too many o

Comments

@grdryn
Copy link
Member

grdryn commented Sep 12, 2023

My thinking is that it might mean fewer different setup steps, and might guard from people accidentally (or intentionally) making manual changes to those resources in that namespace (we would typically manually roll out to separate namespaces for dev/test).

It would also mean that we wouldn't need to remember to manually roll out changes when a PR related to the pipelines is merged

@adelton
Copy link
Contributor

adelton commented Sep 26, 2023

Would Tekton Triggers and webhooks be an alternative approach for that?

@grdryn
Copy link
Member Author

grdryn commented Sep 26, 2023

Possibly 🤔 While we could probably easily have tekton triggers for when PRs get merged, I'm not sure about when any of the k8s resources get changed manually/accidentally?

My thinking is that while we already have ACM periodically (or on demand) synchronizing resources to clusters from the state described in a Git repo, that's what would be useful in this case too, in my opinion.

We already have the manual bootstrap step of oc apply -k acm/registration. If we put the declarative application of the pipeline yamls there too, then it might also simplify the setup for the pipelines while also giving us continuous reconciliation.

WDYT?

@piotrpdev
Copy link
Member

Maybe just merge #108 to solve this?

@grdryn
Copy link
Member Author

grdryn commented Sep 26, 2023

Maybe just merge #108 to solve this?

#108 looks like it is trying to solve something else than this?

@piotrpdev
Copy link
Member

Maybe just merge #108 to solve this?

#108 looks like it is trying to solve something else than this?

My bad, you're right 😅

@piotrpdev piotrpdev added kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/high Important issue that needs to be resolved asap. Releases should not have too many o labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/high Important issue that needs to be resolved asap. Releases should not have too many o
Projects
None yet
Development

No branches or pull requests

3 participants