Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other databases besides sqlite3 in SqlCache #531

Open
pcoccoli opened this issue Jun 27, 2024 · 0 comments
Open

Support other databases besides sqlite3 in SqlCache #531

pcoccoli opened this issue Jun 27, 2024 · 0 comments
Labels
enhancement New feature or request kestrel2 Issue specific to kestrel2 implementation

Comments

@pcoccoli
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Since #529 is done, we should now make SqlCache database-agnostic. Currently it still only works with sqlite3, as it uses the session ID as a filename and creates a SQLAlchemy "connection string" for sqlite.

Describe the solution you'd like
We should be able to specific a cache config (location) in kestrel.yaml so that we can use other DBs, like PostgreSQL. That config should either be a filename (so we use that name as the sqlite database file), direcory (we put a {session_id}.db in that directory), or a SQLAlchemy connection string (which we just use as-is).

Describe alternatives you've considered
Can't think of anything else

Additional context

@pcoccoli pcoccoli added enhancement New feature or request kestrel2 Issue specific to kestrel2 implementation labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kestrel2 Issue specific to kestrel2 implementation
Projects
None yet
Development

No branches or pull requests

1 participant