Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add the update operation #1183

Open
utam0k opened this issue Feb 28, 2023 · 1 comment
Open

Proposal: Add the update operation #1183

utam0k opened this issue Feb 28, 2023 · 1 comment

Comments

@utam0k
Copy link
Member

utam0k commented Feb 28, 2023

How about adding the update operation, which is used in the real world, if you don't mind me asking?12
https://github.com/opencontainers/runtime-spec/blob/main/runtime.md#operations

Also, we already have checkBeforeUpdate for the update operation.
https://github.com/opencontainers/runtime-spec/blob/main/config-linux.md#memory

Footnotes

  1. https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1287-in-place-update-pod-resources#cri-changes ↩

  2. https://github.com/containerd/containerd/blob/a5a4c9ce04d11f4437263b14a2b7b3b8a21e8a0c/pkg/process/init.go#L466 ↩
@utam0k
Copy link
Member Author

utam0k commented Feb 28, 2023

I can make the draft PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@utam0k