Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: TestFdLeaks #4297

Open
kolyshkin opened this issue May 30, 2024 · 1 comment
Open

Flaky test: TestFdLeaks #4297

kolyshkin opened this issue May 30, 2024 · 1 comment

Comments

@kolyshkin
Copy link
Contributor

kolyshkin commented May 30, 2024

Description

From https://github.com/opencontainers/runc/actions/runs/9307874551/job/25620077978?pr=4290 (job is ubuntu-22.04, 1.21.x, -race):

=== RUN   TestFdLeaks
    exec_test.go:1759: extra fd 23 -> 
    exec_test.go:1762: found 1 extra fds after container.Run
--- FAIL: TestFdLeaks (0.22s)

This is the first time I see it.

@YanzhaoLi
Copy link

YanzhaoLi commented Jun 28, 2024

  1. runContainer
  2. fd0 := /proc/thread-self/fd/
  3. runContainer
  4. fd1 := /proc/thread-self/fd/ // Which should be the fds of the calling process

I wonder if the TestFdLeaks is checking the leakage of FDs that was created by Runc, instead of the FDs created by container process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants