Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on Bfd up-transitions and failure-transitions. #1251

Open
AnilKR123 opened this issue Feb 3, 2025 · 2 comments
Open

Clarification on Bfd up-transitions and failure-transitions. #1251

AnilKR123 opened this issue Feb 3, 2025 · 2 comments

Comments

@AnilKR123
Copy link
Contributor

In the GNMI Path: /openconfig-bfd:bfd/interfaces/interface/peers, the state container contains an attribute “failure-transitions” that tracks the number of times that the BFD session has transitioned out of the UP state. In the echo and async sub-containers, there is an attribute for “up-transitions”, which tracks the number of times that the adjacency with the neighbor has transitioned into the UP state." I would like some clarification as to why the failure-transitions are tracked as one attribute in the state container, while there are 2 attributes tracking up-transitions, one for echo and the other for async.

@dplore
Copy link
Member

dplore commented Feb 5, 2025

Hi @AnilKR123, I don't see a history where this is explained. However, it looks unintentional to me?

I would expect to see

/bfd/interfaces/interface/peers/peer/state/failure-transitions
/bfd/interfaces/interface/peers/peer/state/up-transitions

I don't think these leaves are relevant as I think the session state would be reported at the /bfd/interfaces/interface/peers/peer/state container and not within the mode container?

/bfd/interfaces/interface/peers/peer/state/echo/up-transitions	
/bfd/interfaces/interface/peers/peer/state/async/up-transitions	

If you would like to see this change, please feel free to submit a pull request for review

@AnilKR123
Copy link
Contributor Author

Hi Darren,

I submitted a pr to address this: #1252

Thanks,

Anil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants