-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to support ISIS metric #1093
Comments
Hi, thanks for the issue. I interpret the proposed path Can you find 2 or more examples of configuring metric at the ISIS level? I imagine there will be some discussion if we need this additional way to configure isis metrics? For convenience of reviewers, here are the current OC paths for config isis metrics:/network-instances/network-instance/protocols/protocol/isis/global/afi-safi/af/config/metric config isis metric style:/network-instances/network-instance/protocols/protocol/isis/levels/level/config/metric-style configuring isis multi-topology/network-instances/network-instance/protocols/protocol/isis/global/afi-safi/af/multi-topology/config/afi-name |
My bad, I intended to propose this path instead: So it is per interface, but not dependent on the address-family. Let me also change the original post. Sorry for the confusion. |
No, that can't be done (the latter part). The root cause of the issue/behavior you describe is the requirement that metrics in single-topology deployments must be identical. Hence, implementers have a choice: enforce that both IPv4 and IPv6 metrics are always set to the same value in config (and reject other configurations), or ignore (and don't require) one value and always rely on the other to set both. Most implementations on the market follow the latter approach and use the ipv4 metric (aka In my view, simply adding a new metric leaf is not an optimal solution, and there are no implementations that support three configuration levels in the way you describe it. |
Correct, and the use of the ipv4 metric as a single-topology interface metric is exactly the problem this proposal attempts to solve. Let's assume we have an ipv6-only device, i.e. none of the interfaces have ipv4 AF configured. Yet, an ISIS metric has to be configured under ipv4 AF on an interface in order to configure ISIS metric in a single-topology mode . One way to solve it is to use this additional leaf for single-topology metric. |
If you want to pursue this approach, I'd suggest opening a PR that adds/updates/deprecates leafs as necessary to get a full picture of what leafs can be used in the single-topology mode, what leafs are used in multi-topology deployments, etc. it appears that the proposal in its current form de facto deprecates the ipv4/unicast afi/safi metric config (if the intent is to match the current implementations). |
I don't think the proposal causes the ipv4/unicast afi/safi metric to be deprecated. I believe we can follow the current implementation quite closely with the following logic: if in single-topology and metric configured in if in single-topology and metric configured in v4 AF if in single-topology and metric configured in both if in single-topology and metric configured in v6 AF if in multi-topology and metric configured in |
This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days. |
Currently, the ISIS metric can only be defined per Address Family using this OC path:
/network-instances/network-instance/protocols/protocol/isis/interfaces/interface/levels/level/afi-safi/af/config/metric
However, for the IPv6 ISIS metric to be applied the multi-topology has to be enabled. This is true for Juniper, Arista and Cisco XR. Cisco XR enables ISIS multi-topology by default, while Juniper and Arista have single-topology by default.
In the absence of IPv4 AF configured on the device/interface, the ISIS metric under IPv6 AF is ignored, unless multi-topology is enabled.
Proposing to define an OC path for AF-independent metric for ISIS, defined for the level:
[EDITED]
/network-instances/network-instance/protocols/protocol/isis/interfaces/interface/levels/level/config/metric
similar to how the metric-style OC path is defined today:
/network-instances/network-instance/protocols/protocol/isis/levels/level/config/metric-style
Such metric will be used as a metric in ISIS single-topology mode, and can be overridden by the specific metric defined under AF.
From Juniper ISIS metric reference and Juniper ISIS multi-topology reference
From Arista ISIS config guide
IOS XR Configuring Single Topology for IS-IS
The text was updated successfully, but these errors were encountered: